Skip to content

Conversation

@stevenhua0320
Copy link
Contributor

@sbillinge Ready to review

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (775250f) to head (e9c302e).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #365   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          520       520           
=========================================
  Hits           520       520           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea is that the example loads data from files

@stevenhua0320
Copy link
Contributor Author

stevenhua0320 commented Nov 30, 2025

I reviewed the datasource in test files that ends in gr but I don't think they are suitable for the example here as we specified two spacing d and q here. Caden sent me the real example of CeO2.fq data, we have two options here: One is to add that file in the parser_data, recompress it and make a PR here; The other is to just copy the statistics for the measurement here. But I believe the real data has a very long sequence so it is safer to do it in the former way. I also ran a calculated one for CeO2in xy file format, should I also add that one into the parser-data? The data I have put here is the first three entries of the real data.

@sbillinge
Copy link
Contributor

I reviewed the datasource in test files that ends in gr but I don't think they are suitable for the example here as we specified two spacing d and q here. Caden sent me the real example of CeO2.fq data, we have two options here: One is to add that file in the parser_data, recompress it and make a PR here; The other is to just copy the statistics for the measurement here. But I believe the real data has a very long sequence so it is safer to do it in the former way. I also ran a calculated one for CeO2in xy file format, should I also add that one into the parser-data? The data I have put here is the first three entries of the real data.

@cadenmyers13 for this we need diffraction datasets. Maybe not very large though if possible. so .chi or .iq or .fq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants