Skip to content

Conversation

Tieqiong
Copy link
Contributor

@sbillinge please check, thanks

Normalize paths before assert in test_serialization/test_load_multiple to prevent possible Windows short/long name mismatch.

Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (208436c) to head (c14814b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #359   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          520       520           
=========================================
  Hits           520       520           
Files with missing lines Coverage Δ
tests/test_serialization.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge sbillinge merged commit cbf4a11 into diffpy:main Aug 21, 2025
5 checks passed
@sbillinge
Copy link
Contributor

Merged. Do we have to push out a new patch-release for cmi tests to pass?

@Tieqiong
Copy link
Contributor Author

Tieqiong commented Aug 21, 2025

@sbillinge Not really necessary. I already released one in my personal fork and now cmi tests are using that release. Also made an issue diffpy/diffpy.cmi#35 on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants