Skip to content

add deprecation warning to resample function #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

alisnwu
Copy link

@alisnwu alisnwu commented Dec 14, 2024

closes #139

as per discussion in #180 and #207 warnings.warn passes pytest under python 3.13, 3.12, 3.11

@sbillinge ready for review

Screenshot 2024-12-07 at 5 16 14 PM

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (891d774) to head (784bc65).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #234   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          362       362           
=========================================
  Hits           362       362           

@sbillinge sbillinge merged commit d919fef into diffpy:main Dec 15, 2024
5 checks passed
@sbillinge
Copy link
Contributor

Ah, I see, there was a new PR. Ok, np.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate legacy resampler?
2 participants