Move resampler out of parsers, remove relative paths for import #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 7 7
Lines 242 243 +1
=======================================
+ Hits 240 241 +1
Misses 2 2
|
sbillinge
reviewed
Nov 8, 2024
| @@ -16,7 +16,7 @@ | |||
| import numpy | |||
|
|
|||
|
|
|||
| def loadData(filename, minrows=10, headers=False, hdel="=", hignore=None, **kwargs): | |||
| def load_data(filename, minrows=10, headers=False, hdel="=", hignore=None, **kwargs): | |||
There was a problem hiding this comment.
we do not want this change (please see the discussion on #163 ). Please revert.
| @@ -17,7 +17,7 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| class Diffraction_object: | |||
| class DiffractionObject: | |||
There was a problem hiding this comment.
we want this change, but we want to do it as a deprecation. Please see the discussion on #163
added 3 commits
November 8, 2024 13:21
alisnwu
changed the title
|
@sbillinge I've reverted those and now the only changes is the resampler path and removing the relative path imports in parsers |
|
@alisnwu I will close this. I was expecting you to do it this way, but we don't want the committee and the reverts in the history. Sorry for the wasted work of reverting commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #138
All discussions made in #158
@sbillinge Ready for review