Skip to content

add PR test workflow and issue templates #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

Tieqiong
Copy link
Contributor

@Tieqiong Tieqiong commented Jan 1, 2025

@sbillinge please check. This is a temporary pr-test workflow running unit test. Will update during cookie cut.

@Tieqiong
Copy link
Contributor Author

Tieqiong commented Jan 1, 2025

Seems like we need to initialize the action by setting up some kind of Github workflow on main... Or maybe it's some permission issue?

@Tieqiong Tieqiong mentioned this pull request Jan 2, 2025
@sbillinge
Copy link
Contributor

Add cookie to branches in the test on pr workflow and it should ten the tests

@Tieqiong
Copy link
Contributor Author

Tieqiong commented Jan 2, 2025

@sbillinge I don't think that's the issue because we have pull_request listed. Also see #40 which also can't trigger the action

@bobleesj
Copy link

bobleesj commented Jan 2, 2025

@Tieqiong Maybe you could confirm whether it's a permission problem by making a PR to your own main?

@Tieqiong
Copy link
Contributor Author

Tieqiong commented Jan 2, 2025

@bobleesj I tried it on my side, and this is why I was suggesting initializing action by workflow on main. However I'm not sure if it would be the same for organizational repo

@bobleesj
Copy link

bobleesj commented Jan 2, 2025

Yup, seems like it stems from permission

PR to origin/main runs tests-on-pr https://github.com/bobleesj/diffpy.srreal/pull/1
PR to upstream/main does NOT run tests-on-pr #41

@sbillinge
Copy link
Contributor

I will mege this and we can see if it runs the CI on push

@sbillinge sbillinge merged commit 4bf46d2 into diffpy:cookie Jan 2, 2025
1 check passed
@sbillinge
Copy link
Contributor

so it seems that tests-on-pr ran ok when I merged to main. Let's assume everything is ok, and see if it just fixes itself next time. I vaguely remember similar issues like this before that just went away after the first merge.
image

@Tieqiong Tieqiong deleted the workflow branch January 10, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants