-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Untrack files and pyproject.toml edit #9
Conversation
stevenhua0320
commented
Jul 28, 2024
- Add those rst untrack files for authors, license, code_of_conduct etc.
- edit the pyproject.toml in accordance with srmise info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good. In the license file I think we need a copyright statement for 2015 for the trustees of Michigan State University everwhere the license appears, as well as the existing Columbia 2024 statement.
Otherwise, I think I can merge this, but I want to merge the p2 -> p3 branch first when it passes tests.
Try and get that one to pass tests locally after merging upstream/p3 into it. It is ok to make intermediate pushes with tests not passing, but try and do debugging work by running tests locally, not using CI for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can merge this one after we fix the couple of inline comments. I will look for an email for Luke if I can find it and you can add that to the authors in the toml file
diffpy.srmise/doc/source/license.rst
Outdated
============================= | ||
BSD 3-Clause License | ||
|
||
Copyright (c) 2024, The Trustees of Columbia University in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs the updated copyright statements
name = "diffpy.srmise" | ||
dynamic=['version'] | ||
authors = [ | ||
{ name="Simon J.L. Billinge group", email="simon.billinge@gmail.com" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add luke granlund to this.