Skip to content

deprecation remove #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2024
Merged

deprecation remove #78

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2495d2
deprecation remove
stevenhua0320 Aug 16, 2024
b6ffe28
fix to right behavior
stevenhua0320 Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/diffpy/srmise/basefunction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import sys

import numpy as np
from numpy.compat import unicode

from diffpy.srmise.srmiseerrors import SrMiseDataFormatError

Expand Down Expand Up @@ -100,7 +99,7 @@ def __init__(
# arbitrary types, parameters are indexed by these keys as well as
# integer indices. Restricting keys to strings keeps things sane.
for p in self.parameterdict.keys():
if type(p) not in (str, unicode):
if isinstance(p, str):
Copy link
Contributor

@sbillinge sbillinge Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be doing the opposite of the original?

emsg = "Argument parameterdict's keys must be strings."
raise ValueError(emsg)
vals = self.parameterdict.values()
Expand Down