Skip to content

fix: line length to 115 #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix: line length to 115 #164

wants to merge 4 commits into from

Conversation

kwagoner94
Copy link

No description provided.

@sbillinge
Copy link
Contributor

@kwagoner94 looking at this, it seems to me that most of the pre-commit fixes are docformatter (as we knew) and are for the best......we want them. Here is what I suggest as a plan now to move this forward.

  1. Let's make a decision to use the default settings for docformatter. Even if we aren't using 79 line length for hte code, we just make more work for ourselves in the future if we make custom line-lengths in docstrings now.
  2. Create a new branch off of main called docformatter-1
  3. run docformatter on the files that were updated in the first migrate branch. You will probably have to install docformatter in your env as we aren't running it in pre-commit. I don't konw how to do that but I am sure it can be done.
  4. add and commit and make a PR
  5. I will review and merge it (assuming it is all ok)
  6. Then you can sync your main and then checkout migrate and run git merge main which will merge the new main into migrate.
  7. Edit any files in migrate that have custom configurations for docformatter that we added previously. We just want to undo what we did before when we were trying to make docformatter work with longer lines, but per (1.) above we don't want to do any more
  8. Make a PR of migrate. This will have the hand edits that we did together, but it should not generate all the docformatter auto edits in the CI.

Let's try this. If it works, we can apply it to all the branches.

@kwagoner94 kwagoner94 closed this Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants