Skip to content

Conversation

@bobleesj
Copy link

@bobleesj bobleesj commented Nov 19, 2024

To provide an overview: pyobjcryst, diffpy.structure, diffpy.srreal, and sas are optional dependencies in this package.

Once this PR is merged, then diffpy.srreal, and sas APIs need to be updated that cause "13 skipped" below:

Test result:

======= 98 passed, 13 skipped, 1 warning in 0.47s ===============

How to reproduce

conda create -n srfit_env python=3.11          
...activate
conda install --file requirements/conda.txt      
pip install -e . --no-deps    
pytest

@bobleesj
Copy link
Author

@sbillinge ready for review. Look forward to migrating sas next, from v3.0.0 to 6.x.x. APIs look quite different.

@sbillinge sbillinge merged commit 90948c8 into diffpy:cookie Nov 20, 2024
1 check passed
@bobleesj bobleesj deleted the cookie-sas branch November 20, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants