Skip to content

Fix flake8 error lambda functions (E731) by importing erfc from scipy #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix flake8 error lambda functions (E731) by importing erfc from scipy #81

merged 1 commit into from
Aug 22, 2024

Conversation

bobleesj
Copy link 

imac@imacs-iMac diffpy.srfit % python -m diffpy.srfit.tests.run
WARNING:diffpy.srfit.tests:No module named 'sas', SaS tests skipped.
WARNING:diffpy.srfit.tests:Cannot import pyobjcryst, pyobjcryst tests skipped.
WARNING:diffpy.srfit.tests:Cannot import diffpy.srreal, PDF tests skipped.
......ssss................................sssssssssss....ssssss...........................sss..s..............
----------------------------------------------------------------------
Ran 110 tests in 0.213s

OK (skipped=25)

bobleesj
bobleesj commented Aug 21, 2024
View reviewed changes
src/diffpy/srfit/pdf/characteristicfunctions.py
@@ -41,7 +41,7 @@
from numpy import arctanh as atanh
from numpy import ceil, exp, log, log2, pi, sign, sqrt
from numpy.fft import fftfreq, ifft
from scipy.special import erf
from scipy.special import erfc
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

erf was imported to calculate erfc but erfc is provided

@bobleesj bobleesj changed the title Fix flake8 error lambda functions (E731) by importing the func from a library Fix flake8 error lambda functions (E731) by importing ercf from scipy Aug 21, 2024
@bobleesj bobleesj changed the title Fix flake8 error lambda functions (E731) by importing ercf from scipy Fix flake8 error lambda functions (E731) by importing erfc from scipy Aug 21, 2024
sbillinge
sbillinge reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@sbillinge sbillinge merged commit 15d57bd into diffpy:cookie Aug 22, 2024
1 check failed
@bobleesj bobleesj deleted the cookie-lambda-func2 branch August 22, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbillinge sbillinge sbillinge left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobleesj @sbillinge