Skip to content

Fix flake8 error of importing modules at the top (E402) #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbillinge merged 3 commits into from
Aug 20, 2024
Merged

Fix flake8 error of importing modules at the top (E402) #76

sbillinge merged 3 commits into from
Aug 20, 2024

Conversation

@bobleesj
Copy link

@bobleesj bobleesj commented Aug 20, 2024

Test passes

imac@imacs-iMac diffpy.srfit % python -m diffpy.srfit.tests.run
WARNING:diffpy.srfit.tests:No module named 'sas', SaS tests skipped.
WARNING:diffpy.srfit.tests:Cannot import diffpy.structure, Structure tests skipped.
WARNING:diffpy.srfit.tests:Cannot import pyobjcryst, pyobjcryst tests skipped.
WARNING:diffpy.srfit.tests:Cannot import diffpy.srreal, PDF tests skipped.
......ssss...........sss..................sssssssssss....ssssss...........................ssssss..............
----------------------------------------------------------------------
Ran 110 tests in 0.198s

OK (skipped=30)

bobleesj
bobleesj commented Aug 20, 2024
View reviewed changes
Copy link
Author

@bobleesj bobleesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review @sbillinge

src/diffpy/srfit/equation/builder.py
# builders. These will be treated as arguments that need to be
# generated.
for tok in set(args):
# Move genuine varibles to the eqargs dictionary
Copy link
Author

@bobleesj bobleesj Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just cleaning up the syntax ab it.

@bobleesj bobleesj marked this pull request as ready for review August 20, 2024 18:26
sbillinge
sbillinge reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, very nice.

@sbillinge sbillinge merged commit 0927c7a into diffpy:cookie Aug 20, 2024
@sbillinge
Copy link
Contributor

sbillinge commented Aug 20, 2024

@bobleesj thanks for showing passed tests at the top each time, this savedme a lot of heartache merging these.

I think after the flake8 and black things are done, getting the tests running in ci might be the next priority (gh workflows)

@bobleesj
Copy link
Author

bobleesj commented Aug 20, 2024 •
edited
Loading

@bobleesj thanks for showing passed tests at the top each time, this savedme a lot of heartache merging these.

I think after the flake8 and black things are done, getting the tests running in ci might be the next priority (gh workflows)

Got it. I will implement CI after flake8.

Just about two dozens flake8 errors to sort out.

@bobleesj bobleesj deleted the cookie-flake8-E402 branch August 20, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbillinge sbillinge sbillinge left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bobleesj @sbillinge