Skip to content

skpkg: apply black line-length 115 to all files in the project directory #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2025

Conversation

dabeycorn
Copy link

No description provided.

@dabeycorn
Copy link
Author

dabeycorn commented Jun 27, 2025

@sbillinge ready for review. I left the line length at 115 because that was what it was set to. Should I change the value to 79 to stay under 80?

@sbillinge
Copy link
Contributor

wow, great job! Let's leave the line-length at 115 for now, but I would ideally like to change it back to 79 to standardize things. This will generate a bunch of manual work though and we may decide it is not the top priority to do it here. We can make a new branch later when we have all the pre-commit installed and working an run flake8 to see how much work it will be. For now, tihs is good.

I have created a migration branch, so will merge this into migration. Please use that as the base branch for all this skpkg work. I.e., new branches will be created so:

git checkout migration
git pull upstream migration
git checkout -b newbranch

and when you make the PR, select the migration branch on the diffpy repo as the base branch

@sbillinge sbillinge changed the base branch from main to migration June 28, 2025 11:17
@sbillinge sbillinge merged commit 471c795 into diffpy:migration Jun 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants