Skip to content

Add test for prolate spheroid #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

Add test for prolate spheroid #219

merged 2 commits into from
Jun 24, 2025

Conversation

Sparks29032
Copy link
Collaborator

@Sparks29032 Sparks29032 commented Jun 23, 2025

Added test data for prolate spheroid similar to that of oblate spheroid from this commit. Same function is used for all spheroid morphs. Closes #86.

Not user-facing, so no news item added.

Copy link

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.
For best practices, please visit
https://scikit-package.github.io/scikit-package/frequently-asked-questions.html#billinge-group-standards.

Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.23%. Comparing base (ed2c088) to head (627c9a5).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   97.23%   97.23%           
=======================================
  Files          20       20           
  Lines         903      905    +2     
=======================================
+ Hits          878      880    +2     
  Misses         25       25           
Files with missing lines Coverage Δ
tests/test_morphshape.py 95.94% <100.00%> (+0.11%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge
Copy link
Contributor

Not user-facing, so no news item added.

no problem. The preferred workflow for this is to install scikit-package in your env and run package add no-news -m "why not needed" (though double check the syntax.

@sbillinge sbillinge merged commit ea41b24 into diffpy:main Jun 24, 2025
4 of 5 checks passed
@Sparks29032
Copy link
Collaborator Author

Not user-facing, so no news item added.

no problem. The preferred workflow for this is to install scikit-package in your env and run package add no-news -m "why not needed" (though double check the syntax.

Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add test for prolate spheroid
2 participants