Skip to content

skpkg: migrate large doc/manual files #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

Conversation

zmx27
Copy link
Contributor

@zmx27 zmx27 commented Jun 13, 2025

No description provided.

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.23%. Comparing base (b397292) to head (c7b2f71).
Report is 3 commits behind head on migration.

Additional details and impacted files
@@            Coverage Diff             @@
##           migration     #205   +/-   ##
==========================================
  Coverage      97.23%   97.23%           
==========================================
  Files             20       20           
  Lines            903      903           
==========================================
  Hits             878      878           
  Misses            25       25           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zmx27
Copy link
Contributor Author

zmx27 commented Jun 13, 2025

@sbillinge I was able to compress morph_ex1.png using a tool called optipng, pdfmorph.pdf using Ghostscript, and nacl_example.agr using gzip. However, I couldn't figure out how to compress nacl_example.xcf. Instead, I deleted the file and replaced it with nacl_example.png by opening the file in GIMP and exporting it as a PNG file. Ready for review.

If this is okay, please let me know of any other changes I should make. If not, please make a PR from the migration branch to main in upstream after this is merged and close #197!

@sbillinge
Copy link
Contributor

Thanks so much, this is great!

@sbillinge sbillinge merged commit fb1579f into diffpy:migration Jun 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants