Skip to content

Bug (unintentional feature) fixes #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2025
Merged

Conversation

Sparks29032
Copy link
Collaborator

@Sparks29032 Sparks29032 commented Apr 21, 2025

Multiple-morphs and multiple-targets no longer breaks when there are subdirectories within the directories you are applying the morphs in.

Updated the Rw calculation to no longer be Chi-Squared

Changed the color defaults, so morph is blue and target is red. This is as we want users to morph lower-temperature data with higher-temperatures as targets.

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.01%. Comparing base (4914488) to head (426671e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   96.99%   97.01%   +0.02%     
==========================================
  Files          19       19              
  Lines         831      837       +6     
==========================================
+ Hits          806      812       +6     
  Misses         25       25              
Files with missing lines Coverage Δ
tests/test_morphapp.py 99.04% <100.00%> (ø)
tests/test_morphio.py 100.00% <100.00%> (ø)
tests/test_tools.py 98.90% <100.00%> (+0.07%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge sbillinge merged commit 2cd123e into diffpy:main Apr 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants