-
Notifications
You must be signed in to change notification settings - Fork 18
Add shifting morph #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shifting morph #155
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
- Coverage 96.87% 96.85% -0.03%
==========================================
Files 17 18 +1
Lines 769 795 +26
==========================================
+ Hits 745 770 +25
- Misses 24 25 +1
|
try: | ||
hshift = self.hshift | ||
except AttributeError: | ||
hshift = 0 | ||
try: | ||
vshift = self.vshift | ||
except AttributeError: | ||
vshift = 0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code ensures that the vertical/horizontal shifts can be done independent of each other. We can also create two classes: MorphHShift and MorphVShift, but I feel that is overkill.
CodeCov is being silly... the untested line missing coverage is the
line at the end of the test module. |
Ready to merge after review. |
I think there is a way to have it avoid this, but I don't remember how. But for now, I will just merge it. |
There was already a module for shifting morphs, but it has now been integrated into the refinement stack. Tests have been added/modified for this new morph.