Skip to content

Add shifting morph #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Add shifting morph #155

merged 5 commits into from
Nov 13, 2024

Conversation

Sparks29032
Copy link
Collaborator

There was already a module for shifting morphs, but it has now been integrated into the refinement stack. Tests have been added/modified for this new morph.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.85%. Comparing base (7ab7e6f) to head (641b5e7).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_morphshift.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   96.87%   96.85%   -0.03%     
==========================================
  Files          17       18       +1     
  Lines         769      795      +26     
==========================================
+ Hits          745      770      +25     
- Misses         24       25       +1     
Files with missing lines Coverage Δ
tests/test_morphshift.py 96.15% <96.15%> (ø)

Comment on lines +50 to +58
try:
hshift = self.hshift
except AttributeError:
hshift = 0
try:
vshift = self.vshift
except AttributeError:
vshift = 0

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code ensures that the vertical/horizontal shifts can be done independent of each other. We can also create two classes: MorphHShift and MorphVShift, but I feel that is overkill.

@Sparks29032
Copy link
Collaborator Author

CodeCov is being silly... the untested line missing coverage is the

if __name__ == "__main__":
    TestMorphShift()

line at the end of the test module.

@Sparks29032
Copy link
Collaborator Author

Ready to merge after review.

@sbillinge
Copy link
Contributor

CodeCov is being silly... the untested line missing coverage is the

if __name__ == "__main__":
    TestMorphShift()

line at the end of the test module.

I think there is a way to have it avoid this, but I don't remember how. But for now, I will just merge it.

@sbillinge sbillinge merged commit ed8641e into diffpy:main Nov 13, 2024
3 of 5 checks passed
@Sparks29032 Sparks29032 deleted the morphshift branch November 13, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants