Fix behavior for multiple morphs #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sparks29032
changed the title
9 tasks
sbillinge
reviewed
Jun 13, 2024
src/diffpy/pdfmorph/pdfmorphapp.py
Outdated
| epilog="\n".join( | ||
| [ | ||
| "For more information, see the PDFmorph manual." | ||
| "Please report bugs to diffpy-dev@googlegroups.com.", |
There was a problem hiding this comment.
we don't use this any more so it would be good to remove diffpy-dev from everywhere. Let's ask them to report questions and bugs to diffpy-users.
Can we also do a global search and make this change everywhere in all the projects.
There was a problem hiding this comment.
Changed everywhere in PDFmorph. I put in an issue to operation-release-everything about the remaining instances of diffpy-dev that need to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally programmed to error if there are non-PDF files (or directories), better not to error when directory is there since user may save their morphed PDFs in the same directory within a subdirectory.
Also rename outputted
.csvto.txtas it is definitely not a.csv. The format can be read byloadData, so I think it is fine not to change it to an explicit.csv.Also reorder the
--helporder so options involving morphs available and plotting are above options for doing multiple morphs.