Skip to content

skpkg: Migration #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 24, 2025
Merged

skpkg: Migration #87

merged 16 commits into from
Jun 24, 2025

Conversation

tinatn29
Copy link
Contributor

The doc built, and I ran fourigui with a test data. Everything looks good so I think we're good to go!

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (c17c8e3) to head (671d86d).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files           4        4           
  Lines         177      177           
=======================================
  Hits          166      166           
  Misses         11       11           
Files with missing lines Coverage Δ
tests/test_fourigui.py 99.07% <100.00%> (ø)
tests/test_version.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge
Copy link
Contributor

this PR looks a bit dirty (many commits with many merges and things). Was this build from a fully sync'ed main? I think these changes probably should only be on one or two commits?

@tinatn29
Copy link
Contributor Author

tinatn29 commented Jun 24, 2025

@sbillinge yeah, these are commits from the 3 skpkg PRs that we merged into migration. The first PR #82 had many small commits (I made a commit every time I changed a few files). The migration branch on my fork is synced with upstream/migration.

@sbillinge
Copy link
Contributor

Oh, I see. This is the merge from migration into main. Sorry, my bad. It's ok there are many commits in this case.

@sbillinge sbillinge merged commit 275ff4c into diffpy:main Jun 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants