Skip to content

Conversation

@jherico
Copy link
Contributor

@jherico jherico commented Oct 20, 2021

See #969 for the first version of this fix

This is a second attempt that preserves the distinction between spotless.apply.skip and spotless.check.skip

@nedtwigg
Copy link
Member

Looks like it needs a spotless:apply :)

@nedtwigg nedtwigg requested a review from lutovich October 20, 2021 04:42
Copy link
Contributor

@lutovich lutovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Added one tiny comment. Thanks for the fix!

@nedtwigg
Copy link
Member

Thanks to you both for your patience with me :) Let me know if you'd like it to get released now, but I assume it's okay to wait for some other features to pile on to the release train first.

@nedtwigg nedtwigg merged commit 2d3acde into diffplug:main Oct 20, 2021
@jherico jherico deleted the brad_fix-skip branch October 20, 2021 22:34
@jherico
Copy link
Contributor Author

jherico commented Oct 20, 2021

@nedtwigg compared to trying to get traction on the bugs and PRs I've opened against Elasticsearch and Flink this all happened at lightning speed so thanks, one less thing I have to keep track of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants