Skip to content

Added Eclipse 4.21 support. #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Added Eclipse 4.21 support. #947

merged 1 commit into from
Sep 24, 2021

Conversation

fvgh
Copy link
Member

@fvgh fvgh commented Sep 24, 2021

Please have a quick look at the CHANGES.md, since I am no native speaker.

@fvgh fvgh requested a review from nedtwigg September 24, 2021 10:09
@nedtwigg
Copy link
Member

I am no native speaker.

Wow! FWIW we've worked together for a quite a few years now and I would never have guessed that you weren't a native speaker.

(Also I don't care if our docs etc. have english-as-a-second-language spelling errors or unusual idioms as long as the result is readable, but it's really impressive to learn a second language all the way to native fluency in writing, and imo you made it!)

@nedtwigg nedtwigg merged commit 85344bd into main Sep 24, 2021
@nedtwigg nedtwigg deleted the eclipse-4.21 branch September 24, 2021 22:30
@marcphilipp
Copy link

@nedtwigg Do you have an idea when this will be released? I'm hoping it might improve the formatting of sealed classes which is currently very awkward. Case in point: https://github.com/junit-team/junit5/pull/2728/files#diff-1b923dba2a8d4bea6d45efd817e204083a8ae86cb7d80f70b796b4182a8694f2

@nedtwigg
Copy link
Member

Sorry, we're jammed up atm. I'll post to this issue when a release can finally happen again.

#950

@nedtwigg
Copy link
Member

Published in plugin-gradle 5.15.2 and plugin-maven 2.14.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants