Skip to content

Restored scope of transitive dependencies to 'compile' in eclipse-base. #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Restored scope of transitive dependencies to 'compile' in eclipse-base. #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions _ext/eclipse-base/CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
We adhere to the [keepachangelog](https://keepachangelog.com/en/1.0.0/) format (starting after version `3.2.1`).

## [Unreleased]
### Fixed
* Restored scope of transitive dependencies to 'compile'.

## [3.4.0] - 2020-09-23
### Added
Expand Down
4 changes: 2 additions & 2 deletions _ext/eclipse-base/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ ext {
}

dependencies {
implementation("org.eclipse.platform:org.eclipse.core.resources:${VER_ECLIPSE_CORE_RESOURCES}") {
api("org.eclipse.platform:org.eclipse.core.resources:${VER_ECLIPSE_CORE_RESOURCES}") {
exclude group: 'org.eclipse.platform', module: 'org.eclipse.ant.core'
exclude group: 'org.eclipse.platform', module: 'org.eclipse.core.expressions'
exclude group: 'org.eclipse.platform', module: 'org.eclipse.core.filesystem'
}
implementation("org.slf4j:slf4j-api:${VER_SLF4J}")
api("org.slf4j:slf4j-api:${VER_SLF4J}")

testImplementation("org.slf4j:slf4j-simple:${VER_SLF4J}")
}
Expand Down
8 changes: 6 additions & 2 deletions _ext/gradle/java-setup.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,18 @@ apply from: rootProject.file('gradle/changelog.gradle')
version = spotlessChangelog.versionNext
apply from: rootProject.file('gradle/java-setup.gradle')

// Allow declaration of api/compile dependencies
apply plugin: 'java-library'

// Show warning locations
tasks.withType(JavaCompile) {
tasks.withType(JavaCompile) {
options.compilerArgs << "-Xlint:unchecked"
options.compilerArgs << "-Xlint:deprecation"
options.compilerArgs << "-Xlint:deprecation"
}

//Currently testlib is not used by _ext. Hence the external dependencies are added here.
dependencies {
testImplementation "junit:junit:${VER_JUNIT}"
testImplementation "org.assertj:assertj-core:${VER_ASSERTJ}"
testImplementation project(':testlib')
}