Remove deprecated features from plugin-maven, and let plugin-gradle zombie-along #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it had a dedicated block in plugin-maven, which hasn't been in the documentation for a very long time - moved the code to plugin-gradle for now, since plugin-gradle will have a breaking change soon, but not yet
- it had a dedicated block in plugin-maven, which hasn't been in the documentation for a very long time - moved the code to plugin-gradle for now, since plugin-gradle will have a breaking change soon, but not yet
nedtwigg
changed the title
|
@lutovich the important part is the changelog entry https://github.com/diffplug/spotless/blob/41a0d963f448522a78594d15a831029bcf2134a7/plugin-maven/CHANGES.md#removed If this bothers you, I am okay leaving this deprecated code around inside plugin-maven indefinitely. |
|
@nedtwigg I think it is a good idea to remove deprecated formats. Would it be possible to release this change with a major version bump of spotless-maven-plugin? |
|
Yup! Whenever the changelog has BREAKING in it, spotless-changelog will bump the major version. |
lutovich
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point, we can't remove anymore deprecated code from
liborlib-extraunless we also remove the deprecated user-facing parts ofplugin-mavenandplugin-gradle.This PR removes all deprecated functionality from
plugin-maven.I'd like to delay breaking
plugin-gradlefor another week or two. So, I moved all the deprecated parts oflibandlib-extraover toplugin-gradlein a.libdeprecatedpackage. The code will live there just until the very-soon breaking change toplugin-gradle, at which point we'll be free of it forever.So after this PR,
libhas no deprecated code, andplugin-mavenhas no deprecated code.plugin-gradlehas a lot, but it can all be removed in an upcoming cleanup.