SpotlessTask: mark target as task input

[rpalcolea]

SpotlessTask: mark target as task input.

This fixes issue in Gradle 6.x with Warning: Type 'com.diffplug.gradle.spotless.SpotlessTask': property 'target' is not annotated with an input or output annotation

[nedtwigg]

target is not an input on purpose - it is accounted for here:

spotless/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTask.java

Lines 110 to 137 in 3ac6c7c

	protected Iterable<File> target;
	public Iterable<File> getTarget() {
	return target;
	}
	public void setTarget(Iterable<File> target) {
	this.target = Objects.requireNonNull(target);
	}
	/** Internal use only. */
	@InputFiles
	@Deprecated
	public Iterable<File> getInternalTargetInput() {
	return getInternalTarget();
	}
	/** Internal use only. */
	@OutputFiles
	@Deprecated
	public Iterable<File> getInternalTargetOutput() {
	return getInternalTarget();
	}
	private Iterable<File> getInternalTarget() {
	// used to combine the special cache file and the real target
	return Iterables.concat(ImmutableList.of(getCacheFile()), target);
	}

If you want to fix the warning, I think the right thing is to mark it @Internal.

[rpalcolea]

This appears to be a task input from

spotless/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/FormatExtension.java

Line 598 in a7c74de

task.setTarget(target);

I got confused by it

596229e changes that

[nedtwigg]

Yep. Spotless is a weird case because we modify the input (the source code is the input and the output), so we have to do some tricks to make up-to-date checking work.

[nedtwigg]

The PR is failing because of a formatting error, run spotlessApply ;-)

[rpalcolea]

of course! done! thanks @nedtwigg