Modernize build #428
Modernize build #428
Conversation
|
Wow!!! Thanks a ton! |
|
Will take a look at the CI failure tomorrow!
…On Wed, Aug 7, 2019, 3:40 AM Ned Twigg ***@***.***> wrote:
Wow!!! Thanks a ton!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#428?email_source=notifications&email_token=AAKMJPS6YSBPF4A5BJFK7VLQDJ37HA5CNFSM4IJ5IZL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3XQD7I#issuecomment-518980093>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKMJPS6T5WF3RQHTCRUUTLQDJ37HANCNFSM4IJ5IZLQ>
.
|
There was a problem hiding this comment.
I wonder if all references to compile should also be changed to implementation (or api from the java-library plugin if needed) as well.
@ZacSweers @nedtwigg Thoughts? :)
|
They should be updated but I'm not familiar enough with the library to know
which should be implementation vs api. Would rather leave that to the
maintainer as a follow-up.
…On Wed, Aug 7, 2019, 5:10 AM Jonathan Bluett-Duncan < ***@***.***> wrote:
***@***.**** commented on this pull request.
I wonder if all references to compile should also be changed to
implementation (or api from the java-library plugin if needed) as well.
@ZacSweers <https://github.com/ZacSweers> @nedtwigg
<https://github.com/nedtwigg> Thoughts? :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#428?email_source=notifications&email_token=AAKMJPSYCYL672IBMSESIPTQDKGPLA5CNFSM4IJ5IZL2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCAZ36WY#pullrequestreview-271826779>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKMJPR7HY4EPWUDXBLKWCDQDKGPLANCNFSM4IJ5IZLQ>
.
|
| @@ -11,6 +11,7 @@ buildscript { | |||
| classpath "org.ajoberstar:gradle-git-publish:${VER_GRADLE_GIT}" | |||
| classpath "ch.raffael.pegdown-doclet:pegdown-doclet:${VER_PEGDOWN_DOCLET}" | |||
| classpath "gradle.plugin.com.github.spotbugs:spotbugs-gradle-plugin:${VER_SPOTBUGS_PLUGIN}" | |||
| classpath "com.google.guava:guava:27.1-jre" // Force newer version for spotbugs | |||
There was a problem hiding this comment.
Note that this should hopefully not be necessary anymore after Gradle 5.6 is released, which has a lot of work to properly not expose these dependencies on its classpath
|
I started to go through and do the api/implementation stuff. It's clear that'll take some discussion, so I'm going to merge this now so that anybody working on PRs can get the benefit of it while we work out those details. I don't think it's premature to merge this now, since this is clearly better than it was before, even without the full api/implementation changes. |
|
Sounds good to me, @nedtwigg. 👍 |
This brings the build up to a modern version of gradle, and several plugins/configurations along with it
Note that everything here Just Works, but the modern gradle publish plugin uses an env/system property approach for credentials now vs the custom handling that was in place before. Just requires changing the env name currently being used, and is commented in code