Skip to content

Bump the min Gradle and Java requirements to 7.3 and 17 #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nedtwigg merged 4 commits into from
Jul 20, 2025
Merged

Bump the min Gradle and Java requirements to 7.3 and 17 #2540

nedtwigg merged 4 commits into from
Jul 20, 2025

Conversation

@Goooler
Copy link
Member

@Goooler Goooler commented Jul 2, 2025

No description provided.

@nedtwigg
Copy link
Member

nedtwigg commented Jul 2, 2025

@Goooler
Copy link
Member Author

Goooler commented Jul 2, 2025

Will finish this later.

@Goooler Goooler force-pushed the g/20250702/gradle-9 branch 4 times, most recently from cfe3e40 to 7def050 Compare July 3, 2025 13:42
@Goooler Goooler changed the title Bump Gradle to 9.0.0-rc-1 Bump the min Gradle requirement to 7.1 and test on Gradle 9.0.0-rc-1 Jul 3, 2025
@Goooler Goooler force-pushed the g/20250702/gradle-9 branch 2 times, most recently from d94d9c2 to 70d0787 Compare July 3, 2025 14:18
@Goooler Goooler requested a review from Copilot July 3, 2025 14:30

This comment was marked as outdated.

Sign in to view

@Goooler Goooler marked this pull request as ready for review July 3, 2025 14:33
@Goooler
Copy link
Member Author

Goooler commented Jul 3, 2025 •
edited
Loading

This is a significant change; the next Gradle plugin release should be 7.1 or another minor version.

@Goooler Goooler changed the title Bump the min Gradle requirement to 7.1 and test on Gradle 9.0.0-rc-1 Bump the min Gradle requirement to 7.1 and test on 9.0.0-rc-1 Jul 4, 2025
@nedtwigg
Copy link
Member

nedtwigg commented Jul 7, 2025

Amazing! Bumping to Gradle 7.1 indeed brings some great benefits. We get even more if we bump from Java 11 to 17, and if we do that bump then we will require Gradle 7.3 because it is the first version of Gradle which supports Java 17

Whatever path we choose, this PR is a great starting point. But my first instinct is that we should keep our current compat (Java 11 and Gradle 6.1.1) and then go straight to Java 17 and Gradle 7.3. Does that make sense, or is there a reason to retain support for Gradle 7.1 that I am missing?

@Goooler Goooler force-pushed the g/20250702/gradle-9 branch from 254896e to 3b66bf0 Compare July 8, 2025 01:23
@Goooler
Copy link
Member Author

Goooler commented Jul 8, 2025

I'm fine with dropping Java 11 support.

@Goooler Goooler force-pushed the g/20250702/gradle-9 branch from d3e013e to 62973f7 Compare July 8, 2025 01:53
@Goooler Goooler changed the title Bump the min Gradle requirement to 7.1 and test on 9.0.0-rc-1 Bump the min Gradle and Java requirements to 7.3 and 17 Jul 8, 2025
Goooler
Goooler commented Jul 8, 2025
View reviewed changes
testlib/src/test/java/com/diffplug/spotless/java/GoogleJavaFormatStepTest.java
Comment on lines 44 to 45
@Test
@EnabledForJreRange(max = JAVA_15) // google-java-format requires JRE 11+
void behavior18() throws Exception {
Copy link
Member Author

@Goooler Goooler Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

com.diffplug.spotless.Lint$ShortcutException: You are running Spotless on JVM 23. This requires google-java-format of at least 1.17.0 (you are using 1.8).

This is strange.

@Goooler Goooler force-pushed the g/20250702/gradle-9 branch 3 times, most recently from a410746 to 4af88e5 Compare July 11, 2025 07:35
@Goooler Goooler force-pushed the g/20250702/gradle-9 branch from 4af88e5 to 4c80f8e Compare July 14, 2025 06:31
@nedtwigg nedtwigg mentioned this pull request Jul 16, 2025
Merged
@nedtwigg nedtwigg merged commit b64ab47 into main Jul 20, 2025
34 checks passed
@nedtwigg nedtwigg deleted the g/20250702/gradle-9 branch July 20, 2025 20:00
@Goooler Goooler mentioned this pull request Jul 21, 2025
Merged
@nedtwigg
Copy link
Member

nedtwigg commented Sep 24, 2025

Published in plugin-gradle 8.0.0 and plugin-maven 3.0.0.

@dongjoon-hyun dongjoon-hyun mentioned this pull request Oct 22, 2025
Closed
dongjoon-hyun added a commit to apache/spark-kubernetes-operator that referenced this pull request Oct 22, 2025
@dongjoon-hyun
[SPARK-53988] Upgrade Spotless to 8.0.0
4fad7df 
### What changes were proposed in this pull request?

This PR aims to upgrade `Spotless` to 8.0.0 and remove `google-java-format` setting because it's equal to the default now.

### Why are the changes needed?

To bring the latest improvements and bug fixes:
- https://github.com/diffplug/spotless/releases/tag/gradle%2F8.0.0
  - diffplug/spotless#2540
  - diffplug/spotless#2345
  - diffplug/spotless#2404

### Does this PR introduce _any_ user-facing change?

No. This is a test change.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #399 from dongjoon-hyun/SPARK-53988.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This was referenced Nov 22, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Goooler @nedtwigg