update default versions for Eclipse Java and Groovy formatters

[jochenberger]

Retry after #2381 failed and groovy/groovy-eclipse#1607 was resolved.

[jochenberger]

Greclipse update causes issues again. Why does this have to be so hard? I wish they were publishing the core formatter as a regular JAR. :-/

[jochenberger]

There are test failures:

com.diffplug.spotless.extra.groovy.GrEclipseFormatterStepSpecialCaseTest issue_1657_fixed() FAILED (18.8s)
  org.gradle.api.artifacts.ResolveException: [dev.equo.ide:solstice:1.8.1, com.diffplug.durian:durian-swt.os:4.3.1, org.bouncycastle:bcpg-jdk18on:1.80, org.bouncycastle:bcprov-jdk18on:1.80, org.bouncycastle:bcutil-jdk18on:1.80, com.ibm.icu:icu4j:76.1, net.java.dev.jna:jna-platform:5.16.0, jakarta.annotation:jakarta.annotation-api:2.1.1, jakarta.inject:jakarta.inject-api:2.0.1, commons-io:commons-io:2.18.0, commons-logging:commons-logging:1.3.5, org.apache.felix:org.apache.felix.scr:2.2.12, org.eclipse.platform:org.eclipse.compare:3.11.300, org.eclipse.platform:org.eclipse.compare.core:3.8.700, org.eclipse.platform:org.eclipse.core.commands:3.12.300, org.eclipse.platform:org.eclipse.core.contenttype:3.9.600, org.eclipse.platform:org.eclipse.core.databinding:1.13.400, org.eclipse.platform:org.eclipse.core.databinding.observable:1.13.300, org.eclipse.platform:org.eclipse.core.databinding.property:1.10.300, org.eclipse.platform:org.eclipse.core.expressions:3.9.400, org.eclipse.platform:org.eclipse.core.filebuffer
      at com.diffplug.spotless.extra.groovy.GrEclipseFormatterStepSpecialCaseTest.issue_1657_fixed(GrEclipseFormatterStepSpecialCaseTest.java:41)
  Caused by: org.gradle.api.internal.artifacts.ivyservice.TypedResolveException: Could not resolve all files for configuration ':detachedConfiguration1'.
      at app//com.diffplug.spotless.extra.groovy.GrEclipseFormatterStepSpecialCaseTest.issue_1657_fixed(GrEclipseFormatterStepSpecialCaseTest.java:41)
  Caused by: org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find org.eclipse.jdt:org.eclipse.jdt.groovy.core:5.7.0.
  Searched in the following locations:
    - https://repo.maven.apache.org/maven2/org/eclipse/jdt/org.eclipse.jdt.groovy.core/5.7.0/org.eclipse.jdt.groovy.core-5.7.0.pom
  Required by:
      root project :

I'm at a loss.

[nedtwigg]

Why does this have to be so hard?

Eclipse p2, haha. One way around it was for Spotless itself to create and publish fat jars. That was laborious and error-prone, and fell more than a year out of date.

So we switched to the Equo p2 implementation, which lets us download metadata straight from the Eclipse p2 sources. The p2 metadata can say when a jar is published on mavenCentral vs when it is only available via p2, and this lets us use pure-maven for JDT.

For the error you inlined above, the Groovy's p2 metadata is now claiming that the jar is published on mavencentral, but it is not. That's the error. If they did publish all their artifacts on mavencentral, that would be amazing! Or if they didn't claim maven coordinates, Equo p2 would download it from their p2 update site, which is what the previous metadata claimed.

This p2 stuff sucks. If there were any other Groovy formatter, I would consider killing the p2 support and deprecating the formatters that rely on it...

[jochenberger]

This is all so sad.

For the error you inlined above, the Groovy's p2 metadata is now claiming that the jar is published on mavencentral, but it is not.

So that changed for the current release? Bummer, I was happy that they activated the content.xml creation again. So we're probably going to have to wait another 3 months. 🫤

This p2 stuff sucks. If there were any other Groovy formatter, I would consider killing the p2 support and deprecating the formatters that rely on it...

Maybe we can build something upon https://docs.openrewrite.org/recipes/groovy/format/autoformat. I haven't had a closer look yet though, but I have pretty high hopes in the OpenRewrite project.

[jochenberger]

OpenRewrite does publish their artifacts on Maven: https://central.sonatype.com/artifact/org.openrewrite/rewrite-groovy/overview
And there's https://github.com/openrewrite/rewrite/blob/main/rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParser.java
This might actually work.

[jochenberger]

So, is something still missing here or can it be merged?

[nedtwigg]

Just needed a little changelog tweak, merge ahoy! Thanks for sticking with this. Hopefully we can get openrewrite's formatter going and make this whole p2 thing a little less critical.

[nedtwigg]

Published in plugin-gradle 7.0.4 and plugin-maven 2.44.5

[chrisrueger]

If they did publish all their artifacts on mavencentral, that would be amazing!

Maybe @merks has a comment about this, as he does lots of release stuff at Eclipse. (related to #2458 (comment))

[merks]

Can you boil down the question? 😁

[chrisrueger]

Can you boil down the question? 😁

I just thought that maybe you have a comment on the availability of Eclipse jars on Maven Central.
It seems this project is struggeling a bit with p2 and some libs. And since I notice you are doing lots of Eclipse release work, I thought you might have a comment on that.

Specifically spotless uses parts of JDT Formatter to bring Eclipse code formatting to Maven / Gradle CLI. Apparently p2 is causing problems somehow and some jar's are not available on maven central although p2 is telling that.

So we switched to the Equo p2 implementation, which lets us download metadata straight from the Eclipse p2 sources. The p2 metadata can say when a jar is published on mavenCentral vs when it is only available via p2, and this lets us use pure-maven for JDT.

For the error you inlined above, the Groovy's p2 metadata is now claiming that the jar is published on mavencentral, but it is not. That's the error. If they did publish all their artifacts on mavencentral, that would be amazing! Or if they didn't claim maven coordinates, Equo p2 would download it from their p2 update site, which is what the previous metadata claimed.

Hopefully the maintainers here could clarify their question. I am not involved in the this project, just a happy user :)
I just thought I'd connect you and maybe something might change to the better in the future.

[merks]

Every Eclipse release publishes effectively everything to Maven Central.

• https://repo.maven.apache.org/maven2/org/eclipse/jdt/
• https://repo.maven.apache.org/maven2/org/eclipse/platform/
• https://repo.maven.apache.org/maven2/org/eclipse/pde/

Also SNAPSHOTS are built daily:

https://repo.eclipse.org/content/repositories/eclipse-snapshots/org/eclipse/

If someone has a specific question, just @ mention me and I'll have a look.

[jochenberger]

This is more about the artifacts from the groovy formatter than the core project's ones.

[merks]

For what it's worth, the Platform, EMF, and BIRT (in progress) all use the CBI aggregator to map a subset of the IUs in a p2 repository into a Maven-compatible format that can be published to Maven Central, conforming to the requires for the POM content. It's not very well documented but it works very well...

Basically what to aggregate, from where to aggregate, and how to map the OSGi metadata to Maven is specified like this:

https://github.com/eclipse-emf/org.eclipse.emf/blob/master/releng/org.eclipse.emf.releng/publish/aggr/EMF.aggr

And then the entire publishing process is driven like this:

https://github.com/eclipse-emf/org.eclipse.emf/blob/master/releng/org.eclipse.emf.releng/publish/publishToMaven.jenkinsfile

[nedtwigg]

The places where maven artifacts are missing are CDT and Groovy/Greclipse, which I think are outside of @merks' domain, but thanks very much for the info on how the mapping gets defined!