Skip to content

Use palantir-java-format 2.57.0 on Java 21 #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 14, 2025
Merged

Use palantir-java-format 2.57.0 on Java 21 #2447

merged 4 commits into from
Mar 14, 2025

Conversation

matsev
Copy link
Contributor

@matsev matsev commented Mar 13, 2025 •
edited
Loading

Updates the Palantir Java formatter to version 2.57.0 for improved code formatting for Java 21

ref: palantir/palantir-java-format#952 and palantir/palantir-java-format#1211

Goooler
Goooler approved these changes Mar 14, 2025
View reviewed changes
@Goooler Goooler changed the title bump palantir to version 2.57.0 Use palantir-java-format 2.57.0 on Java 21 Mar 14, 2025
@Goooler Goooler merged commit f6da1c4 into diffplug:main Mar 14, 2025
16 checks passed
@matsev matsev deleted the palantir-2_57_0 branch March 14, 2025 07:23
@nedtwigg
Copy link
Member

nedtwigg commented Apr 8, 2025

Published in plugin-gradle 7.0.3 and plugin-maven 2.44.4

@jglick
Copy link
Contributor

jglick commented May 19, 2025

This has been causing problems in Jenkins plugins using the default configuration because certain switch statements are formatted one way when Maven is run using JDK 17 and another when it is run using JDK 21, despite the fact that the source level of the project is a constant (17).

spotless/lib/src/main/java/com/diffplug/spotless/java/PalantirJavaFormatStep.java

Lines 86 to 88 in 6f1919f

public static String defaultVersion() {
return JVM_SUPPORT.getRecommendedFormatterVersion();
}
seems wrong; it should be inspecting the source level of the project (as defined by maven-compiler-plugin), without reference to the version of Java which happens to be running the tool.

@jglick jglick mentioned this pull request May 19, 2025
Merged
6 tasks
@basil basil mentioned this pull request Jun 3, 2025
Closed
slawekjaranowski added a commit to mojohaus/mojo-parent that referenced this pull request Jun 12, 2025
@slawekjaranowski
Use spotless / palantirJavaFormat - 2.56.0 for all JDKs
68e4702 
Spotless start using palantir-java-format 2.57.0 on Java 21 - on older jdks different versions are used.

It causes a different code format depends on using JDK

references:
 - diffplug/spotless#2447
 - diffplug/spotless#2503
 - palantir/palantir-java-format#1320

Additionally, we can't use older spotless on JDK8
@slawekjaranowski slawekjaranowski mentioned this pull request Jun 12, 2025
Merged
slawekjaranowski added a commit to slawekjaranowski/maven-parent that referenced this pull request Jun 12, 2025
@slawekjaranowski
Use spotless / palantirJavaFormat - 2.56.0 for all JDKs
13255c8 
Spotless start using palantir-java-format 2.57.0 on Java 21 - on older jdks different versions are used.

It causes a different code format depends on using JDK

references:
 - diffplug/spotless#2447
 - diffplug/spotless#2503
 - palantir/palantir-java-format#1320

As issue - diffplug/spotless#2503 was closed, reverting spotless plugin to an older version is not a resolution.
@slawekjaranowski slawekjaranowski mentioned this pull request Jun 12, 2025
Merged
slawekjaranowski added a commit to slawekjaranowski/maven-parent that referenced this pull request Jun 13, 2025
@slawekjaranowski
Use spotless / palantirJavaFormat - 2.56.0 for all JDKs
c0bd503 
Spotless start using palantir-java-format 2.57.0 on Java 21 - on older jdks different versions are used.

It causes a different code format depends on using JDK

references:
 - diffplug/spotless#2447
 - diffplug/spotless#2503
 - palantir/palantir-java-format#1320

As issue - diffplug/spotless#2503 was closed, reverting spotless plugin to an older version is not a resolution.
slawekjaranowski added a commit to apache/maven-parent that referenced this pull request Jun 13, 2025
@slawekjaranowski
Use spotless / palantirJavaFormat - 2.56.0 for all JDKs
9014c35 
Spotless start using palantir-java-format 2.57.0 on Java 21 - on older jdks different versions are used.

It causes a different code format depends on using JDK

references:
 - diffplug/spotless#2447
 - diffplug/spotless#2503
 - palantir/palantir-java-format#1320

As issue - diffplug/spotless#2503 was closed, reverting spotless plugin to an older version is not a resolution.
slawekjaranowski added a commit to mojohaus/mojo-parent that referenced this pull request Jun 13, 2025
@slawekjaranowski
Use spotless / palantirJavaFormat - 2.56.0 for all JDKs
335f685 
Spotless start using palantir-java-format 2.57.0 on Java 21 - on older jdks different versions are used.

It causes a different code format depends on using JDK

references:
 - diffplug/spotless#2447
 - diffplug/spotless#2503
 - palantir/palantir-java-format#1320

Additionally, we can't use older spotless on JDK8
slawekjaranowski added a commit to mojohaus/mojo-parent that referenced this pull request Jun 13, 2025
@slawekjaranowski
Use spotless / palantirJavaFormat - 2.56.0 for all JDKs
4bdba1c 
Spotless start using palantir-java-format 2.57.0 on Java 21 - on older jdks different versions are used.

It causes a different code format depends on using JDK

references:
 - diffplug/spotless#2447
 - diffplug/spotless#2503
 - palantir/palantir-java-format#1320

Additionally, we can't use older spotless on JDK8
slawekjaranowski added a commit to mojohaus/mojo-parent that referenced this pull request Jun 13, 2025
@slawekjaranowski
Use spotless / palantirJavaFormat - 2.56.0 for all JDKs
ca812c1 
Spotless start using palantir-java-format 2.57.0 on Java 21 - on older jdks different versions are used.

It causes a different code format depends on using JDK

references:
 - diffplug/spotless#2447
 - diffplug/spotless#2503
 - palantir/palantir-java-format#1320

Additionally, we can't use older spotless on JDK8
@jglick jglick mentioned this pull request Jun 26, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goooler Goooler Goooler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matsev @nedtwigg @jglick @Goooler