Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied common Spotless Eclipse framework to Groovy-Eclipse #244

Merged
merged 6 commits into from
Jul 19, 2018

Conversation

fvgh
Copy link
Member

@fvgh fvgh commented May 5, 2018

Using Spotless Eclipse Framework.
Upgraded from groovy-eclipse version 2.9.1 to 2.9.2.
Replaced groovy-eclipse code replacements by Spotless services.
Removed Eclipse/Idea support for embedded sources.

Using Spotless Eclipse Framework.
Upgraded from groovy-eclipse version 2.9.1 to 2.9.2.
Replaced groovy-eclipse code replacements by Spotless services.
Removed Eclipse/Idea support for embedded sources.
@nedtwigg
Copy link
Member

nedtwigg commented May 6, 2018

LGTM! Is it assigned to me for review, or is there another action you'd like me to take?

fvgh added 5 commits July 18, 2018 06:27
…ned from P2 (instead of manually copy).

Fixed test files (preventing formatting by spotlessApply task.
… from 3.12 to 3.13).

Compiler (AST generation) errors are reported as Warnings. The handling can be changed by property 'ignoreFormatterProblems'.
Fixed warning introduced during OSGI version upgrade.
@fvgh fvgh merged commit 28a6073 into master Jul 19, 2018
@fvgh fvgh deleted the ext_eclipse_groovy branch July 20, 2018 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants