Use gradle-buildconfig-plugin to generate dependency versions #2705

Activity

1. Goooler

   added the

   Task

   issue type on Oct 28, 2025
2. Goooler

   added

   enhancement

   easy

   on Oct 28, 2025
3. nedtwigg commented on Nov 3, 2025

   

   nedtwigg

   on Nov 3, 2025

   Member

   More actions

   I'm not familiar with this, but I'm open to it. What is the problem that it solves?
4. Goooler commented on Nov 4, 2025

   

   Goooler

   on Nov 4, 2025

   MemberAuthor

   More actions

   @renovate-bot send the updates like #2345, we have to update GoogleJavaFormatStep.java manually to reflect the latest version string. If we apply the build config stuff, the latest version in the lib will always be refed by

   .add(17, BuildConfig.VERSION_GJF); // default version 

   and BuildConfig.VERSION_GJF always reflects the latest version bumped by @renovate-bot.

   👀React with 👀1Reacted by Jonathan Bluett-Duncan
5. nedtwigg commented on Nov 5, 2025

   

   nedtwigg

   on Nov 5, 2025

   Member

   More actions

   Wow! Great idea, I like it!

   👍React with 👍1Reacted by Jonathan Bluett-Duncan
6. builtbyjuls commented on Sep 8, 2026

   

   builtbyjuls

   on Sep 8, 2026

   Contributor

   More actions

   Hi, I would like to work on this. I reviewed current main now that #2704 has been merged, and the google-java-format defaults are now split by JVM compatibility.

   Is the intended scope now to generate BuildConfig.VERSION_GJF from the version in libs.google.java.format and use it for the JVM 21+ recommended default, while keeping the JVM 17 default at 1.28.0 and the JVM 25 minimum at 1.30.0?

   I would keep the dependency bump in #2706 outside this PR so the change remains focused on wiring the version catalog value into the generated build config.
7. Goooler commented on Sep 8, 2026

   

   Goooler

   on Sep 8, 2026

   MemberAuthor

   More actions

   addMin(25, BuildConfig.VERSION_GJF) for

   spotless/lib/src/main/java/com/diffplug/spotless/java/GoogleJavaFormatStep.java

   Line 124 in 7bd31e1

   .addMin(25, "1.30.0") // import module (JEP 511) requires google-java-format >= 1.30.0 (https://github.com/google/google-java-format/issues/1213)

   Always ref the latest dependency version in the buildconfig
8. builtbyjuls commented on Sep 8, 2026

   

   builtbyjuls

   on Sep 8, 2026

   Contributor

   More actions

   Thanks! One concern: if only the Java 25 minimum uses BuildConfig.VERSION_GJF, while the Java 21+ default remains hardcoded to 1.30.0, a future Renovate update would make Spotless select 1.30.0 and then reject it for being below the new minimum.

   Should both the Java 21+ default and the Java 25 minimum use BuildConfig.VERSION_GJF, while Java 17 remains on 1.28.0?
9. Goooler commented on Sep 8, 2026

   

   Goooler

   on Sep 8, 2026

   Last edited by Goooler

   MemberAuthor

   More actions

   Good question! I was wrong. We should only replace

   spotless/lib/src/main/java/com/diffplug/spotless/java/GoogleJavaFormatStep.java

   Line 126 in 7bd31e1

   .add(21, "1.30.0"); // default on JVM 21+ (1.30.0+ handles `import module` in RemoveUnusedImports on JVM 25+)

   instead of addMin. That's the default one when users use googleJavaFormat.

   I filed this FR a long time ago and haven't contributed to this codebase for a while, so I missed some context!
10. Goooler

    closed this as completedin #3045on Sep 15, 2026