Get `ide` to work with Java 11 / Eclipse 4.17

[nedtwigg]

Eclipse 4.17 requires Java 11+ to run. If you try to run it with Java 8, there are no explicit warnings about using the wrong version, and eclipse will start successfully. However, you won't actually be able to use it, it's functionally broken.

If you start ide with Java 11, the task fails like so:

> Task :ide:ideSetupP2
!SESSION 2020-09-17 10:04:12.926 -----------------------------------------------
eclipse.buildId=unknown
java.version=11.0.8
java.vendor=AdoptOpenJDK
BootLoader constants: OS=macosx, ARCH=x86_64, WS=cocoa, NL=en_US
Framework arguments:  -application org.eclipse.equinox.p2.director -repository https://download.eclipse.org/eclipse/updates/4.17/R-4.17-202009021800/,https://download.eclipse.org/wildwebdeveloper/releases/0.9.1/ -artifactRepository file:///Users/ntwigg/.goomph/shared-bundles -installIU org.eclipse.platform.ide,org.eclipse.jdt.feature.group,org.eclipse.ui.views.log,org.eclipse.wildwebdeveloper.feature.feature.group -profile OomphIde -destination file:///Users/ntwigg/Documents/dev/mytakedotorg/ide/build/oomph-ide.app -bundlepool /Users/ntwigg/.goomph/shared-bundles -p2.os macosx -p2.ws cocoa -p2.arch x86_64
Command-line arguments:  -application org.eclipse.equinox.p2.director -clean -consolelog -repository https://download.eclipse.org/eclipse/updates/4.17/R-4.17-202009021800/,https://download.eclipse.org/wildwebdeveloper/releases/0.9.1/ -artifactRepository file:///Users/ntwigg/.goomph/shared-bundles -installIU org.eclipse.platform.ide,org.eclipse.jdt.feature.group,org.eclipse.ui.views.log,org.eclipse.wildwebdeveloper.feature.feature.group -profile OomphIde -destination file:///Users/ntwigg/Documents/dev/mytakedotorg/ide/build/oomph-ide.app -bundlepool /Users/ntwigg/.goomph/shared-bundles -p2.os macosx -p2.ws cocoa -p2.arch x86_64

!ENTRY org.eclipse.osgi 4 0 2020-09-17 10:04:12.949
!MESSAGE FrameworkEvent ERROR
!STACK 0
org.osgi.framework.BundleException: Cannot support framework extension bundles without a public addURL(URL) method on the framework class loader: org.eclipse.osgi.compatibility.state_1.1.0.v20170516-1513 [36]
        at org.eclipse.osgi.storage.FrameworkExtensionInstaller.addExtensionContent0(FrameworkExtensionInstaller.java:104)
        at org.eclipse.osgi.storage.FrameworkExtensionInstaller.addExtensionContent(FrameworkExtensionInstaller.java:79)
        at org.eclipse.osgi.internal.loader.SystemBundleLoader$SystemModuleClassLoader.loadFragments(SystemBundleLoader.java:129)
        at org.eclipse.osgi.internal.loader.SystemBundleLoader.loadClassLoaderFragments(SystemBundleLoader.java:111)
        at org.eclipse.osgi.internal.loader.BundleLoader.loadFragments(BundleLoader.java:282)
        at org.eclipse.osgi.container.ModuleWiring.loadFragments(ModuleWiring.java:273)
        at org.eclipse.osgi.container.ModuleContainer.applyDelta(ModuleContainer.java:710)
        at org.eclipse.osgi.container.ModuleContainer.resolveAndApply(ModuleContainer.java:511)
        at org.eclipse.osgi.container.ModuleContainer.resolve(ModuleContainer.java:457)
        at org.eclipse.osgi.container.ModuleContainer.refresh(ModuleContainer.java:1001)
        at org.eclipse.osgi.container.ModuleContainer$ContainerWiring.dispatchEvent(ModuleContainer.java:1382)
        at org.eclipse.osgi.container.ModuleContainer$ContainerWiring.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

!ENTRY org.eclipse.core.net 1 0 2020-09-17 10:04:13.413
!MESSAGE System property http.nonProxyHosts has been set to local|*.local|169.254/16|*.169.254/16 by an external source. This value will be overwritten using the values from the preferences
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.eclipse.ecf.provider.filetransfer.httpclient4.SNIAwareHttpClient$1 (file:/Users/ntwigg/.goomph/p2-bootstrap/4.7.2/plugins/org.eclipse.ecf.provider.filetransfer.httpclient4_1.1.200.v20170314-0133.jar) to method sun.security.ssl.SSLSocketImpl.setHost(java.lang.String)
WARNING: Please consider reporting this to the maintainers of org.eclipse.ecf.provider.filetransfer.httpclient4.SNIAwareHttpClient$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
Installing org.eclipse.platform.ide 4.17.0.I20200902-1800.
Installing org.eclipse.jdt.feature.group 3.18.500.v20200902-1800.
Installing org.eclipse.ui.views.log 1.2.1200.v20200828-0938.
Installing org.eclipse.wildwebdeveloper.feature.feature.group 0.9.1.202005041657.
An error occurred while installing the items
Installation failed.
 session context was:(profile=OomphIde, phase=org.eclipse.equinox.internal.p2.engine.phases.Install, operand=null --> [R]com.google.gson 2.8.2.v20180104-1110, action=org.eclipse.equinox.internal.p2.touchpoint.eclipse.actions.InstallBundleAction).
 Could not acquire the framework manipulator service.
Caused by: Application failed, log file location: /Users/ntwigg/.goomph/p2-bootstrap/4.7.2/configuration/1600362252277.log

!ENTRY org.eclipse.equinox.p2.engine 4 4 2020-09-17 10:04:23.625
!MESSAGE An error occurred while installing the items
!SUBENTRY 1 org.eclipse.equinox.p2.engine 4 0 2020-09-17 10:04:23.626
!MESSAGE session context was:(profile=OomphIde, phase=org.eclipse.equinox.internal.p2.engine.phases.Install, operand=null --> [R]com.google.gson 2.8.2.v20180104-1110, action=org.eclipse.equinox.internal.p2.touchpoint.eclipse.actions.InstallBundleAction).
!SUBENTRY 1 org.eclipse.equinox.p2.engine 4 0 2020-09-17 10:04:23.626
!MESSAGE Could not acquire the framework manipulator service.
!STACK 0
java.lang.IllegalStateException: Could not acquire the framework manipulator service.
        at org.eclipse.equinox.internal.p2.touchpoint.eclipse.LazyManipulator.loadDelegate(LazyManipulator.java:45)
        at org.eclipse.equinox.internal.p2.touchpoint.eclipse.LazyManipulator.getConfigData(LazyManipulator.java:108)
        at org.eclipse.equinox.internal.p2.touchpoint.eclipse.actions.InstallBundleAction.installBundle(InstallBundleAction.java:75)
        at org.eclipse.equinox.internal.p2.touchpoint.eclipse.actions.InstallBundleAction.execute(InstallBundleAction.java:32)
        at org.eclipse.equinox.internal.p2.engine.ParameterizedProvisioningAction.execute(ParameterizedProvisioningAction.java:39)
        at org.eclipse.equinox.internal.p2.engine.Phase.mainPerform(Phase.java:184)
        at org.eclipse.equinox.internal.p2.engine.Phase.perform(Phase.java:96)
        at org.eclipse.equinox.internal.p2.engine.PhaseSet.perform(PhaseSet.java:47)
        at org.eclipse.equinox.internal.p2.engine.Engine.perform(Engine.java:77)
        at org.eclipse.equinox.internal.p2.engine.Engine.perform(Engine.java:45)
        at org.eclipse.equinox.internal.provisional.p2.director.PlanExecutionHelper.executePlan(PlanExecutionHelper.java:42)
        at org.eclipse.equinox.internal.provisional.p2.director.PlanExecutionHelper.executePlan(PlanExecutionHelper.java:24)
        at org.eclipse.equinox.internal.p2.director.app.DirectorApplication.executePlan(DirectorApplication.java:813)
        at org.eclipse.equinox.internal.p2.director.app.DirectorApplication.planAndExecute(DirectorApplication.java:806)
        at org.eclipse.equinox.internal.p2.director.app.DirectorApplication.performProvisioningActions(DirectorApplication.java:793)
        at org.eclipse.equinox.internal.p2.director.app.DirectorApplication.run(DirectorApplication.java:1111)
        at org.eclipse.equinox.internal.p2.director.app.DirectorApplication.start(DirectorApplication.java:1293)
        at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
        at com.diffplug.gradle.eclipserunner.EquinoxLauncher$Running.run(EquinoxLauncher.java:190)
        at com.diffplug.gradle.eclipserunner.EquinoxLauncher$Running.access$100(EquinoxLauncher.java:172)
        at com.diffplug.gradle.eclipserunner.EquinoxLauncher.run(EquinoxLauncher.java:163)
        at com.diffplug.gradle.eclipserunner.JarFolderRunner.run(JarFolderRunner.java:37)
        at com.diffplug.gradle.eclipserunner.JarFolderRunnerExternalJvm$RunOutside.run(JarFolderRunnerExternalJvm.java:126)
        at com.diffplug.gradle.JavaExecable.main(JavaExecable.java:134)

It's really important for Goomph to support the latest version of eclipse. Goomph still works with 4.17 with the mavenCentral plugin, but the ide plugin needs to work too. It would be nice for Goomph to stay compatible with Java 8, but if we have to bump our minimum required Java to 11, I'm okay with that.

Fixing this is important, but I don't expect to have time to look at this further until early 2021. PRs are welcome!

[nedtwigg]

Related: #127, #99, #69.

[drkstr101]

Ugg, what a pain (RE supporting both Java 8/11). I need a version of ANTLWorks that only works with 1.8, but VScode and now Eclipse are forcing Java 11. I better start getting ahead of this. Any ideas on where to get started, or is that the first steps here?

[nedtwigg]

The most obvious place to start would be upgrading the eclipse launcher jars and code. The jars are defined here:

goomph/build.gradle

Lines 44 to 53 in d95be31

	// eclipse 4.7.2
	compileOnly 'org.eclipse.platform:org.eclipse.core.jobs:3.9.2'
	compileOnly 'org.eclipse.platform:org.eclipse.core.runtime:3.13.0'
	compileOnly 'org.eclipse.platform:org.eclipse.core.resources:3.12.0'
	compileOnly 'org.eclipse.platform:org.eclipse.equinox.common:3.9.0'
	compileOnly 'org.eclipse.platform:org.eclipse.ui.workbench:3.110.1'
	compileOnly 'org.eclipse.pde:org.eclipse.pde.core:3.11.100'
	compileOnly 'org.eclipse.jdt:org.eclipse.jdt.launching:3.9.51'
	// from 4.6.3 cuz that's the latest one
	compileOnly 'org.eclipse.emf:org.eclipse.emf.ecore:2.12.0'

And the code is here:
https://github.com/diffplug/goomph/tree/main/src/main/java/com/diffplug/gradle/eclipserunner/launcher

How to do it

A long time ago, you couldn't apply a gradle plugin to the build.gradle of the build that built it (aka you could not bootstrap). That is fixed now, so you could use eclipseMavenCentral to get the latest 4.17 jars into build.gradle.

And as for the eclipserunner.launcher package, that code was just straight copy-pasted from the super-old Eclipse Mars.2. I'm not sure which package it came from originally, but it shouldn't be too hard to track down.

Past those two things (updating the jars, updating the .launcher package), I would just follow a stacktrace, then try to fix it. Follow the next stacktrace, try to fix that.

As mentioned before, these upgrades are likely to drop support for all the old Eclipse's. But I think that's fine, goomph isn't adding a ton of features, so I think it's fine to say "if you want Eclipse < 4.17, use Goomph vBlah".

[drkstr101]

Awesome, thanks for the head start! I will start plugging away at it and see if I can make any progress on this. I will have more time at the end of the week, so I'll post back then with any results.

[drkstr101]

Sorry it took me so long to get back to this. I have all my DevOps up and running on Java 11 now, so hopefully I can make some progress on this.

[drkstr101]

FYI I am going to start testing this in watheia/gradle-and-eclipse-rcp, so I will add a branch there for java-11.

[drkstr101]

@nedtwigg When you have a min, could you please give me some additional context on where I can look into making changes to the following in the build.gradle

apply from: 干.file('base/java8.gradle')
apply from: 干.file('base/changelog.gradle')
apply from: 干.file('base/gradle-plugin.gradle')
apply from: 干.file('base/maven.gradle')
apply from: 干.file('base/bintray.gradle')
apply from: 干.file('spotless/freshmark.gradle')
apply from: 干.file('spotless/java.gradle')

I'm not exactly sure if those symbols are intentional or some kind of encoding error, but I was more curious about where I can locate, and make changes to, the referenced Gradle file.

Cheers, and thank you!

[nedtwigg]

https://github.com/diffplug/blowdryer

[drkstr101]

Ah, of course. Says so right above that block of code!

Thanks for the speedy reply. =)

[nedtwigg]

Sorry for brief answer from phone, juggling sick kids. The longer answer is to swap the comment here:

goomph/settings.gradle

Lines 22 to 25 in 292e0eb

	blowdryerSetup {
	github 'diffplug/blowdryer-diffplug', 'tag', '3.2.4'
	//devLocal '../blowdryer-diffplug'
	}

and clone this repo in a folder next to goomph: https://github.com/diffplug/blowdryer-diffplug

[drkstr101]

No worries, I just clicked the link at the top of the README to find it.

FYI I am attempting to get the CI workspace set up here; https://gitlab.com/watheia/diffplug

If you have a GitLab account I can add you on if you wish.

Once it's working I will be able to run "Auto DevOps" against graalvm-java11 native images on a DO droplet. I expect this to blow up in my face, but hopefully, it will at least shake out a few issues with java-next compatibility.

[drkstr101]

Unfortunately, decoupled projects seem to break classpath resolution with p2 targets. You want me to see if I can take a stab at that first, assuming it's not just something stupid in my setup?

(pass) https://gitlab.com/watheia/diffplug/-/jobs/805215016
(fail) https://gitlab.com/watheia/diffplug/-/jobs/805235920

Note: At this point, I'm just trying to get everything up and running on java-8, before I move on to the more challenging bit. I have done a few experiments locally to test the waters, but I need to integrate cross-project builds to make any real progress.