Implement notebook side navigation #138
Conversation
edongashi
force-pushed
the
edon/notebook-nav
branch
from
30a987a to
263eda3
Compare
edongashi
force-pushed
the
edon/notebook-nav
branch
from
636faf9 to
ee33e88
Compare
| ### Version 0.1.4 | ||
|
|
||
| - Added UI feedback on data export. | ||
| - Added support for column generalization. | ||
| - Removed anonymized count value in low count rows. | ||
| - Added relative noise column in combined view. | ||
| - Added side navigation in Notebooks. |
There was a problem hiding this comment.
Not sure why the whole file diff. Maybe changed CRLF to LF...
There was a problem hiding this comment.
It seems you dropped the single space indentation from each list item. Maybe your editor doesn't like it or you pressed Shift-Tab by mistake?
cristianberneanu
left a comment
cristianberneanu
left a comment
There was a problem hiding this comment.
Looks nice! 👍
A few suggestions for future changes:
- when scrolling, show the current step in bold;
- drop the bullet from non-actionable steps (like "Data preview").
src/Notebook/notebook-nav.tsx
Outdated
| @@ -0,0 +1,189 @@ | |||
| import React, { useCallback, useContext, useEffect, useRef } from 'react'; | |||
There was a problem hiding this comment.
Nice! Github shows build warnings during review :)
| ### Version 0.1.4 | ||
|
|
||
| - Added UI feedback on data export. | ||
| - Added support for column generalization. | ||
| - Removed anonymized count value in low count rows. | ||
| - Added relative noise column in combined view. | ||
| - Added side navigation in Notebooks. |
There was a problem hiding this comment.
It seems you dropped the single space indentation from each list item. Maybe your editor doesn't like it or you pressed Shift-Tab by mistake?
You mean the line should continue without breaking? In which case we'd have 3 user-interaction steps: Import -> Column Selection -> Export. Will have to figure out how to make it look right because it's not out of the box from ant. |
Yes, that is what I had in mind.
If it takes too much work, then let's skip it. It is not that useful. |
No description provided.