Add derivatives for RealFunctions #7
Conversation
JaapWijnen
force-pushed
the
feature/realfunctions-derivatives
branch
16 times, most recently
from
fc82a10 to
142f057
Compare
Also adds RealFunctions conformance to SIMD types and their derivatives
JaapWijnen
force-pushed
the
feature/realfunctions-derivatives
branch
from
142f057 to
448b9ce
Compare
|
Perhaps there should be some tests that use some of the generated functions to have some coverage? Otherwise LGTM |
|
Right, absolutely, good point haha. |
| ) | ||
| try realFunctionsSIMDExtension.write(to: realFunctionSIMDFileURL, atomically: true, encoding: .utf8) | ||
|
|
||
| let floatingPointTypes: [String] = ["Float", "Double"] |
There was a problem hiding this comment.
minor: there are aliases Float16, Float32, Float64, so you could make this an array of bit widths rather than strings, which might clean up some other parts of the code?
| component: "\(floatingPointType)+RealFunctions+Derivatives.swift", | ||
| directoryHint: .notDirectory | ||
| ) | ||
| let type = floatingPointType |
There was a problem hiding this comment.
This is ... odd? Is this changing the type from String to something else (in which case annotate it?); or just defining a shorthand name; or ...?
There was a problem hiding this comment.
ah that was there to match the same structure as around line 65. Removed it now.
|
I also didn't check the vjps for correctness, but assuming they're right and we have some basic unit tests, everything looks good to me. |
|
Happy I added some tests cause I did find two incorrect vjps 😬 copy paste error... |
JaapWijnen
force-pushed
the
feature/realfunctions-derivatives
branch
from
4259585 to
8fd0b5a
Compare
JaapWijnen
force-pushed
the
feature/realfunctions-derivatives
branch
from
4e1643a to
6364866
Compare
JaapWijnen
force-pushed
the
feature/realfunctions-derivatives
branch
from
6364866 to
8caa407
Compare
This MR adds derivatives to types conforming to RealFunctions such as Float and Double
This also adds RealFunctions conformance to SIMD types and their derivatives.
This is achieved through generating default implementations for the
SIMDprotocol and also generating concrete implementations that can have derivatives attached to them. This is required since we can't have default derivative implementations for protocol requirements.Most of the code is generated by a plugin.