Skip to content

Conversation

@tautschnig
Copy link
Collaborator

When updating the sole member of a struct we can just use the new value.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test that exercises this case?

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.93%. Comparing base (4f59921) to head (b87c98a).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/util/simplify_expr.cpp 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8724      +/-   ##
===========================================
- Coverage    79.94%   79.93%   -0.01%     
===========================================
  Files         1698     1698              
  Lines       187677   187681       +4     
  Branches        73       73              
===========================================
- Hits        150032   150022      -10     
- Misses       37645    37659      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

When updating the sole member of a struct we can just use the new value.
@tautschnig
Copy link
Collaborator Author

Is there a test that exercises this case?

While there already was a test that made us reach the newly added statements I have now also added a check in a .desc file.

@tautschnig tautschnig force-pushed the simplify-with-single-member branch from 15e76c2 to b87c98a Compare October 31, 2025 14:25
@tautschnig tautschnig merged commit c914c2c into diffblue:develop Oct 31, 2025
40 of 41 checks passed
@tautschnig tautschnig deleted the simplify-with-single-member branch October 31, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants