Skip to content

Enable all cbmc regression tests that are passing to run with new SMT backend #8051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

esteffin
Copy link
Contributor

This PR adds 130 tests from regression/cbmc to the list of tests that is run with the new incremental SMT2 solver.
This is done by removing the no-new-smt exclusion flag from the tests as the current policy is to run the tests with the incremental SMT2 solver by default.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This commit adds 130 tests from regression/cbmc to the list of tests
that is run with the new incremental SMT2 solver.

Notice that some tests are related to unsupported features, that
however are removed by the simplification steps before the solver is
invoked making them tractable.
@esteffin esteffin requested a review from a team November 20, 2023 11:55
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5cfcbc4) 79.09% compared to head (1932655) 79.09%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8051   +/-   ##
========================================
  Coverage    79.09%   79.09%           
========================================
  Files         1699     1699           
  Lines       196516   196516           
========================================
+ Hits        155432   155434    +2     
+ Misses       41084    41082    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteffin esteffin merged commit 8769bb5 into diffblue:develop Nov 20, 2023
@esteffin esteffin deleted the esteffin/add-cbmc-regression-to-incremental-smt branch November 20, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants