Shadow Memory: Refactoring, enabling tests and minor doxygen improvements. #7868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NlightNFotis
requested review from
martin-cs,
peterschrammel,
kroening and
tautschnig
as code owners
peterschrammel
approved these changes
Aug 29, 2023
| @@ -691,7 +690,17 @@ static exprt get_matched_expr_cond( | |||
| return expr_cond; | |||
| } | |||
|
|
|||
| // TODO: doxygen? | |||
| // TODO: FOtis - revisit. | |||
| @@ -22,7 +22,6 @@ Author: Peter Schrammel | |||
| #include <util/ssa_expr.h> | |||
| #include <util/std_expr.h> | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
This commit should be squashed into the respective previous commits.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7868 +/- ##
===========================================
- Coverage 78.84% 77.88% -0.97%
===========================================
Files 1699 1699
Lines 195229 195294 +65
===========================================
- Hits 153935 152098 -1837
- Misses 41294 43196 +1902
☔ View full report in Codecov by Sentry. |
When setting shadow memory for pointer types the value is replicated by applying left shift and combining the shifted values with bitwise-or. However the SAT solver does not support bitwise-or for pointer types. This commit changes the way the replication is done for pointer types by converting them to an unsigned bitvector of the pointer type size, performing the shift and bitwise-or on this bitvector type and then casting it to pointer at the end.
Marking as CORE all the shadow memory regression tests that are now passing. The remaining regression tests that are still marked as KNOWNBUG will be added as soon as the implementation will be fixed.
esteffin
force-pushed
the
shadow_mem_rev
branch
from
27f32b9 to
4655ef4
Compare
TGWDB
approved these changes
Aug 30, 2023
Windows requires alloca to be defined otherwise an invariant will be violated (the invariant violation will be changed in another subsequent PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second part of our work on the
set_field, this is enabling some tests that are now passing after our bug fixes, refactoring code to use a more modern style at places, and adding some doxygen documentation for some of the functions.This is really just a checkin of our current work in progress before we move forward with more tests && refactors.
Work done with @esteffin