Skip to content

CONTRACTS: re-enable side effect checking in assigns/frees clauses (HOTFIX) #7699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

remi-delmas-3000
Copy link
Collaborator

@remi-delmas-3000 remi-delmas-3000 commented May 3, 2023

This PR re-enables side effect checking in functions called from assigns and frees clauses that was mistakenly disabled by #7671, and adds a new test that checks that side effect checking is actually performed.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This PR re-enables side effect checking in functions called from assigns
and frees clauses that was mistakenly disabled by PR 7671, and adds
a new test that checks that side effect checking is actually performed.
@remi-delmas-3000 remi-delmas-3000 added aws Bugs or features of importance to AWS CBMC users aws-high Code Contracts Function and loop contracts labels May 3, 2023
@remi-delmas-3000 remi-delmas-3000 requested a review from qinheping May 3, 2023 16:05
@qinheping
Copy link
Collaborator

Thank you!
Does the error message say it is caused by side-effect assign/free clause? I couldn't tell from test.desc.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fa60087) 78.51% compared to head (445527d) 78.51%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7699   +/-   ##
========================================
  Coverage    78.51%   78.51%           
========================================
  Files         1674     1674           
  Lines       191940   191946    +6     
========================================
+ Hits        150709   150715    +6     
  Misses       41231    41231           
Impacted Files Coverage Δ
...t/contracts/dynamic-frames/dfcc_spec_functions.cpp 91.81% <100.00%> (+0.29%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -0,0 +1,54 @@
#include <stdbool.h>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this include.

@remi-delmas-3000 remi-delmas-3000 merged commit bce472f into diffblue:develop May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users aws-high Code Contracts Function and loop contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants