Skip to content

CHC solver: generalization #7268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2022
Merged

CHC solver: generalization #7268

merged 1 commit into from
Oct 21, 2022

Conversation

kroening
Copy link
Member

This adds generalization for loop invariants using the frequency of disjuncts in the candidate invariant for the frame where the inductiveness check has failed.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This adds generalization for loop invariants using the frequency of
disjuncts in the candidate invariant for the frame where the inductiveness
check has failed.
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 78.00% // Head: 78.01% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c92a05c) compared to base (61577ae).
Patch coverage: 80.80% of modified lines in pull request are covered.

❗ Current head c92a05c differs from pull request most recent head 38aabd6. Consider uploading reports for the commit 38aabd6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #7268    +/-   ##
=========================================
  Coverage    78.00%   78.01%            
=========================================
  Files         1621     1625     +4     
  Lines       187273   187407   +134     
=========================================
+ Hits        146089   146201   +112     
- Misses       41184    41206    +22     
Impacted Files Coverage Δ
src/solvers/smt2/smt2_conv.cpp 65.46% <66.66%> (-0.01%) ⬇️
src/cprover/solver_types.cpp 76.92% <76.92%> (ø)
src/cprover/inductiveness.cpp 78.35% <78.35%> (ø)
src/cprover/solver.cpp 92.00% <81.81%> (+10.46%) ⬆️
src/cprover/generalization.cpp 84.21% <84.21%> (ø)
src/cprover/inductiveness.h 100.00% <100.00%> (ø)
src/cprover/propagate.cpp 74.28% <100.00%> (+0.75%) ⬆️
src/cprover/solver_types.h 93.10% <100.00%> (+4.21%) ⬆️
src/goto-instrument/unwind.cpp 100.00% <100.00%> (ø)
src/ansi-c/expr2c.cpp 67.27% <0.00%> (-0.05%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments describing what the methods are supposed to do would be really helpful.

@kroening kroening merged commit 333c256 into develop Oct 21, 2022
@kroening kroening deleted the chc_generalization branch October 21, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants