Skip to content

SMT2 back-end: support empty compound types #7223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

Do not construct equalities over expressions the type of which has zero bit width. Also, permit pointer arithmetic over objects of such type (which was previously fixed in 6b09359 for the propositional back-end).

Fixes: #7185

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Do not construct equalities over expressions the type of which has zero
bit width. Also, permit pointer arithmetic over objects of such type
(which was previously fixed in 6b09359 for the propositional back-end).

Fixes: diffblue#7185
@tautschnig tautschnig force-pushed the bugfixes/7185-empty-compound branch from 5da2ad0 to c3d954e Compare October 8, 2022 13:19
@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Base: 77.89% // Head: 77.89% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c3d954e) compared to base (8115bb9).
Patch coverage: 83.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7223   +/-   ##
========================================
  Coverage    77.89%   77.89%           
========================================
  Files         1616     1616           
  Lines       186791   186808   +17     
========================================
+ Hits        145498   145514   +16     
- Misses       41293    41294    +1     
Impacted Files Coverage Δ
.../src/java_bytecode/java_bytecode_convert_class.cpp 94.18% <ø> (ø)
...src/java_bytecode/java_bytecode_convert_method.cpp 97.69% <ø> (ø)
jbmc/src/java_bytecode/java_bytecode_language.cpp 92.81% <ø> (ø)
jbmc/src/java_bytecode/java_object_factory.cpp 94.40% <ø> (ø)
jbmc/src/java_bytecode/java_string_literals.cpp 94.54% <ø> (ø)
src/analyses/cfg_dominators.h 100.00% <ø> (ø)
...le-sensitivity/value_set_pointer_abstract_object.h 100.00% <ø> (ø)
src/ansi-c/ansi_c_convert_type.h 100.00% <ø> (ø)
src/ansi-c/ansi_c_internal_additions.cpp 90.12% <ø> (ø)
src/ansi-c/c_typecheck_base.h 100.00% <ø> (ø)
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit 459dd62 into diffblue:develop Oct 8, 2022
@tautschnig tautschnig deleted the bugfixes/7185-empty-compound branch October 8, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invariant violation when using --z3
3 participants