Skip to content

Document state of smt2_incremental_decision_proceduret #7062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thomasspriggs
Copy link
Contributor

This PR documents the state of smt2_incremental_decision_proceduret.
This is useful because the state has grown large enough that saying a bit more about the purpose of each piece of state will help with maintaining it.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@TGWDB TGWDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #7062 (d7b3f48) into develop (8258529) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #7062      +/-   ##
===========================================
- Coverage    77.88%   77.86%   -0.03%     
===========================================
  Files         1569     1569              
  Lines       180995   180995              
===========================================
- Hits        140968   140929      -39     
- Misses       40027    40066      +39     
Impacted Files Coverage Δ
..._incremental/smt2_incremental_decision_procedure.h 75.00% <ø> (ø)
...c/solvers/smt2_incremental/convert_expr_to_smt.cpp 82.18% <0.00%> (-6.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Because the state has grown large enough that saying a bit more about
the purpose of each piece of state will help with maintaining it.
@thomasspriggs thomasspriggs force-pushed the tas/smt_state_documentation branch from ce3dff5 to d7b3f48 Compare August 9, 2022 14:04
@thomasspriggs thomasspriggs merged commit 78efc2c into diffblue:develop Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants