solvers.a is not used in goto-analyzer so remove the dependency #7026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-cs
force-pushed
the
fix/goto-analyzer-does-not-need-solvers
branch
from
febd802 to
95bbf91
Compare
tautschnig
approved these changes
Jul 22, 2022
Codecov Report
@@ Coverage Diff @@
## develop #7026 +/- ##
========================================
Coverage 77.86% 77.86%
========================================
Files 1569 1569
Lines 180995 180995
========================================
Hits 140929 140929
Misses 40066 40066 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Also ping @peterschrammel and @chris-ryder |
chris-ryder
approved these changes
Aug 6, 2022
Note that the module dependencies already blocks including files from solvers/.
martin-cs
force-pushed
the
fix/goto-analyzer-does-not-need-solvers
branch
from
95bbf91 to
e845363
Compare
|
Thanks @chris-ryder . I have rebased and will merge once CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the module dependencies already blocks including files from
solvers/.