-
Notifications
You must be signed in to change notification settings - Fork 277
Mark CBMC version 5.62.0 #7019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark CBMC version 5.62.0 #7019
Conversation
NlightNFotis
commented
Jul 21, 2022
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please hold back as I'd like to have a regression fix included that I'm about to PR.
That PR is #7020. |
@tautschnig, Yep, happy to wait - feel free to unblock this when you're ready. |
Codecov Report
@@ Coverage Diff @@
## develop #7019 +/- ##
========================================
Coverage 77.88% 77.88%
========================================
Files 1569 1569
Lines 180891 180891
========================================
Hits 140878 140878
Misses 40013 40013 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#7020 is now merged, if you could please rebase then I'd be happy for this release to proceed.
I don't think we even need to rebase. If I remember correctly we normally tag the merge commit as the release, which will include any other changes merged to develop. |
Yeah, I don't think we need to rebase (as there are no conflicts in the files edited), but I have issued a re-run of the failed jobs (given that they are required). |