Skip to content

Add smt response storage classes #6425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thomasspriggs
Copy link
Contributor

This PR adds smt response storage classes for type safe storage of parsed responses from SMT2 solvers.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #6425 (e5db980) into develop (f6fa03c) will increase coverage by 0.02%.
The diff coverage is 99.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6425      +/-   ##
===========================================
+ Coverage    75.98%   76.00%   +0.02%     
===========================================
  Files         1524     1527       +3     
  Lines       164299   164454     +155     
===========================================
+ Hits        124843   125000     +157     
+ Misses       39456    39454       -2     
Impacted Files Coverage Δ
src/solvers/smt2_incremental/smt_responses.def 87.50% <87.50%> (ø)
src/solvers/smt2_incremental/smt_responses.cpp 100.00% <100.00%> (ø)
src/solvers/smt2_incremental/smt_responses.h 100.00% <100.00%> (+100.00%) ⬆️
unit/solvers/smt2_incremental/smt_responses.cpp 100.00% <100.00%> (ø)
src/solvers/smt2_incremental/smt_commands.h 100.00% <0.00%> (ø)
...it/solvers/smt2_incremental/smt_to_smt2_string.cpp 100.00% <0.00%> (ø)
...rc/solvers/smt2_incremental/smt_to_smt2_string.cpp 93.96% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce2680b...e5db980. Read the comment docs.

@thomasspriggs thomasspriggs force-pushed the tas/smt_response_classes branch from e1f0767 to 7a3cbb6 Compare November 2, 2021 21:27
The python script would previously count the following example as 3
tests where it should have counted it as 2 tests -
`TEMPLATE_TEST_CASE("a,b", "[core]", class_at, class_bt)`
For type safe storage of parsed responses from SMT2 solvers.
@thomasspriggs thomasspriggs force-pushed the tas/smt_response_classes branch from 7a3cbb6 to e5db980 Compare November 3, 2021 10:50
@thomasspriggs thomasspriggs merged commit ce3fcaa into diffblue:develop Nov 3, 2021
@thomasspriggs thomasspriggs deleted the tas/smt_response_classes branch November 3, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants