Skip to content

SMT-LIB2 now outputs negative integer/rational literals correctly #6301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

kroening
Copy link
Member

SMT-LIB2 does not have negative integer/rational literals, and it's
necessary to use a unary minus.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

SMT-LIB2 does not have negative integer/rational literals, and it's
necessary to use a unary minus.
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #6301 (45222f0) into develop (63203b1) will decrease coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6301      +/-   ##
===========================================
- Coverage    75.98%   75.98%   -0.01%     
===========================================
  Files         1510     1510              
  Lines       163465   163473       +8     
===========================================
  Hits        124208   124208              
- Misses       39257    39265       +8     
Impacted Files Coverage Δ
src/solvers/smt2/smt2_conv.cpp 66.50% <0.00%> (-0.20%) ⬇️
src/util/floatbv_expr.cpp 0.00% <0.00%> (ø)
src/util/floatbv_expr.h 73.58% <ø> (ø)
src/util/ieee_float.cpp 88.01% <0.00%> (ø)
src/util/ieee_float.h 85.71% <ø> (ø)
...yses/variable-sensitivity/abstract_environment.cpp 95.02% <100.00%> (ø)
...-sensitivity/abstract_environment/to_predicate.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be17ef4...45222f0. Read the comment docs.

@kroening kroening marked this pull request as ready for review August 16, 2021 19:01
@kroening kroening merged commit 24dd735 into develop Aug 16, 2021
@kroening kroening deleted the smt2_constant branch August 16, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants