VSD - max array length #6293
Merged
VSD - max array length #6293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jezhiggins
force-pushed
the
vsd-max-array-length
branch
2 times, most recently
from
a638126 to
15ffbfe
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6293 +/- ##
========================================
Coverage 75.97% 75.98%
========================================
Files 1508 1510 +2
Lines 163380 163465 +85
========================================
+ Hits 124131 124208 +77
- Misses 39249 39257 +8
Continue to review full report at Codecov.
|
jezhiggins
force-pushed
the
vsd-max-array-length
branch
2 times, most recently
from
3c72914 to
f304bb9
Compare
martin-cs
approved these changes
Aug 12, 2021
src/analyses/variable-sensitivity/variable_sensitivity_configuration.h
Outdated
Show resolved
Hide resolved
jezhiggins
force-pushed
the
vsd-max-array-length
branch
from
59881b8 to
917fd7a
Compare
The "smash" array abstraction sets the maximum size of the full_array_abstract_object to 1. All writes to the array are merged, and all reads return the same value.
jezhiggins
force-pushed
the
vsd-max-array-length
branch
from
917fd7a to
0a3b7e3
Compare
jezhiggins
force-pushed
the
vsd-max-array-length
branch
from
c4426ea to
5705e60
Compare
Default n is 10. Additional --vsd-max-array-elements options gives finer control.
jezhiggins
force-pushed
the
vsd-max-array-length
branch
from
5705e60 to
63203b1
Compare
jezhiggins
commented
Aug 13, 2021
| { | ||
| return object_factory->wrap_with_context(abstract_object); | ||
| return object_factory->config(); | ||
| } |
There was a problem hiding this comment.
Bit of a diff mismatch. add_object_context is redundant and was removed. configuration is a new member function, which we need :)
jezhiggins
requested review from
chrisr-diffblue and
peterschrammel
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent large arrays getting unwieldy, add a configuration parameter that limits the number of entries they have.
Writes beyond the maximum index are all written to the same location, merging with any previous writes.
--vsd-arrays smashoption, which sets the maximum size to 1. All writes to the array are merged, and all reads return the same value.--vsd-arrays up-to-n-elementsoption. Default n is 10,--vsd-max-array-elementsoptions gives finer control. (I would have liked n to be an additional parameter to --vsd-arrays, but that would have required significant rework in the arguments parsing and it's just not worth it.)