-
Notifications
You must be signed in to change notification settings - Fork 277
Refactored parsing rules for function contracts #6195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored parsing rules for function contracts #6195
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #6195 +/- ##
===========================================
+ Coverage 67.40% 75.32% +7.92%
===========================================
Files 1157 1456 +299
Lines 95236 161128 +65892
===========================================
+ Hits 64197 121376 +57179
- Misses 31039 39752 +8713
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, but we should explain why they are necessary in the commit messages.
1. Renamed cprover_contract to cprover_function_contract. 2. Renamed cprover_contract_sequence to cprover_function_contract_sequence. 3. Renamed cprover_contract_sequence_opt to cprover_function_contract_sequence_opt. 4. Created cprover_contract_assigns_opt and added it to cprover_function_contract. This allows us to reuse the assigns clause for loop contracts in the future.
d242154
to
a2705f1
Compare
The following four changes were made:
This was done so we can reuse cprover_contract_assigns_opt for future use in Loop Contracts.