Skip to content

r_w_ok_valid_negated/test-no-cp was fixed in 3acdb52dd6e #5989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

tautschnig
Copy link
Collaborator

3acdb52 fixed the bug that had (also) caused
cbmc-primitives/r_w_ok_valid_negated/test-no-cp.desc to fail.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

3acdb52 fixed the bug that had (also) caused
cbmc-primitives/r_w_ok_valid_negated/test-no-cp.desc to fail.
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #5989 (bc7f0a3) into develop (e76d811) will increase coverage by 0.04%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5989      +/-   ##
===========================================
+ Coverage    75.12%   75.16%   +0.04%     
===========================================
  Files         1435     1444       +9     
  Lines       156301   157263     +962     
===========================================
+ Hits        117416   118204     +788     
- Misses       38885    39059     +174     
Impacted Files Coverage Δ
src/solvers/smt2/smt2_conv.h 100.00% <ø> (ø)
src/memory-analyzer/gdb_api.cpp 86.89% <50.00%> (ø)
unit/memory-analyzer/gdb_api.cpp 86.46% <94.73%> (ø)
src/solvers/smt2/smt2_conv.cpp 60.86% <100.00%> (+1.47%) ⬆️
src/util/std_expr.h 92.62% <0.00%> (-0.53%) ⬇️
.../memory-analyzer/memory_analyzer_parse_options.cpp 53.48% <0.00%> (ø)
src/util/c_types_util.h 29.03% <0.00%> (ø)
...rc/memory-analyzer/memory_analyzer_parse_options.h 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e42cc6c...bc7f0a3. Read the comment docs.

@kroening kroening merged commit c0ea367 into diffblue:develop Apr 2, 2021
@tautschnig tautschnig deleted the fixed1 branch April 2, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants