Skip to content

Add fault-localization regression tests #5934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2021

Conversation

tautschnig
Copy link
Collaborator

Moving the (three) tests from a dedicated folder to cbmc to run them,
also making use of all three configurations that the cbmc folder is
being tested with.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig force-pushed the fault-localization-tests branch from 2ab9462 to b60faa5 Compare March 15, 2021 22:35
@tautschnig tautschnig self-assigned this Mar 16, 2021
@tautschnig tautschnig force-pushed the fault-localization-tests branch from b60faa5 to a17a51c Compare March 17, 2021 00:01
@tautschnig tautschnig force-pushed the fault-localization-tests branch from a17a51c to 8fc89c3 Compare March 17, 2021 17:06
@tautschnig tautschnig force-pushed the fault-localization-tests branch 5 times, most recently from 387dff9 to 612ba76 Compare March 17, 2021 22:19
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #5934 (40309c0) into develop (0e34169) will increase coverage by 0.16%.
The diff coverage is 71.38%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5934      +/-   ##
===========================================
+ Coverage    74.25%   74.41%   +0.16%     
===========================================
  Files         1445     1446       +1     
  Lines       157479   157783     +304     
===========================================
+ Hits        116933   117417     +484     
+ Misses       40546    40366     -180     
Impacted Files Coverage Δ
src/ansi-c/expr2c.cpp 58.48% <ø> (ø)
src/goto-checker/properties.cpp 72.56% <ø> (+5.32%) ⬆️
src/util/format_expr.cpp 84.87% <0.00%> (-0.79%) ⬇️
src/util/pointer_expr.cpp 72.82% <0.00%> (-18.96%) ⬇️
src/util/pointer_expr.h 77.34% <0.00%> (-22.66%) ⬇️
src/util/simplify_expr_class.h 100.00% <ø> (ø)
...riable-sensitivity/abstract_object/index_range.cpp 100.00% <ø> (ø)
src/solvers/flattening/bv_pointers.cpp 81.26% <13.04%> (-3.36%) ⬇️
src/ansi-c/c_typecheck_expr.cpp 75.17% <75.00%> (-0.01%) ⬇️
src/util/simplify_expr.cpp 75.93% <76.92%> (-8.56%) ⬇️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae0bcf...40309c0. Read the comment docs.

@tautschnig tautschnig removed their assignment Mar 17, 2021
tautschnig added 3 commits May 2, 2021 11:18
The XML schema requires that goto_trace appears within a result node,
which was the case for all-properties verifiers, but not for
stop-on-fail.

While at it, also cleanup JSON output to use the goto_tracet API.
cbmc --localize-faults --xml-ui reports its result in a
fault-localization node.
Moving the (three) tests from a dedicated folder to cbmc to run them,
also making use of all three configurations that the cbmc folder is
being tested with.
@tautschnig tautschnig force-pushed the fault-localization-tests branch from c2ebbf7 to 40309c0 Compare May 2, 2021 11:20
@tautschnig tautschnig merged commit 598c554 into diffblue:develop May 2, 2021
@tautschnig tautschnig deleted the fault-localization-tests branch May 2, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants