-
Notifications
You must be signed in to change notification settings - Fork 277
Support for non-glibc linux which use musl-libc #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.travis.yml
Outdated
- env: NAME="CPP-LINT" | ||
script: scripts/travis_lint.sh || true | ||
script: scripts/run_lint.sh master HEAD || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That appears to revert an earlier commit?!
Reverted back to travis_lint.sh |
@zemanlx, please squash 3790cab into d9fdbb37. |
3790cab
to
810476f
Compare
818fc3f
to
3bb0e01
Compare
This needs a rebase, and would then be ready to go! |
cc17aa4
to
c22c600
Compare
@kroening it has been rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to have slightly more verbose commit messages. Commit messages should answer the "why" question.
Change `#ifdef __linux__` and `#if defined(__linux__)` when it really means *linux with glibc*. To avoid failures and be more specific it is now adding `defined(__GLIBC__)` to check if `glibc` is present.
- new environment in matrix that run compilation in alpine docker container. - reordering matrix environments from the longest run to the shortest run time. - rewrite of `script` to be able to run compilation in a container if needed.
c22c600
to
50c28c3
Compare
@tautschnig I have added more information why I have done these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for all the clarification!
…res_cause_explosion Turning parse failures into non-critical failures
By applying these changes we are able to compile cbmc code and run successfully all tests in alpine linux.