Skip to content

Support for non-glibc linux which use musl-libc #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2017

Conversation

zemanlx
Copy link

@zemanlx zemanlx commented Feb 24, 2017

By applying these changes we are able to compile cbmc code and run successfully all tests in alpine linux.

.travis.yml Outdated
- env: NAME="CPP-LINT"
script: scripts/travis_lint.sh || true
script: scripts/run_lint.sh master HEAD || true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That appears to revert an earlier commit?!

@zemanlx
Copy link
Author

zemanlx commented Feb 24, 2017

Reverted back to travis_lint.sh

@peterschrammel
Copy link
Member

@zemanlx, please squash 3790cab into d9fdbb37.

@zemanlx zemanlx force-pushed the feature/compile-on-musl branch from 3790cab to 810476f Compare February 27, 2017 10:52
@zemanlx zemanlx force-pushed the feature/compile-on-musl branch from 818fc3f to 3bb0e01 Compare February 27, 2017 16:10
@kroening
Copy link
Member

This needs a rebase, and would then be ready to go!

@zemanlx zemanlx force-pushed the feature/compile-on-musl branch from cc17aa4 to c22c600 Compare February 28, 2017 09:24
@zemanlx
Copy link
Author

zemanlx commented Mar 1, 2017

@kroening it has been rebased.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have slightly more verbose commit messages. Commit messages should answer the "why" question.

Vlastimil Zeman added 2 commits March 10, 2017 11:58
Change `#ifdef __linux__` and `#if defined(__linux__)` when it really
means *linux with glibc*. To avoid failures and be more specific
it is now adding `defined(__GLIBC__)` to check if `glibc` is present.
- new environment in matrix that run compilation in alpine docker container.
- reordering matrix environments from the longest run to the shortest run time.
- rewrite of `script` to be able to run compilation in a container if needed.
@zemanlx zemanlx force-pushed the feature/compile-on-musl branch from c22c600 to 50c28c3 Compare March 10, 2017 12:04
@zemanlx
Copy link
Author

zemanlx commented Mar 10, 2017

@tautschnig I have added more information why I have done these changes.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for all the clarification!

@kroening kroening merged commit 0139558 into diffblue:master Mar 13, 2017
NathanJPhillips pushed a commit to NathanJPhillips/cbmc that referenced this pull request Sep 6, 2018
…res_cause_explosion

Turning parse failures into non-critical failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants