Simplification of pointer comparison: do not assume numeric types #5689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we cannot (or chose not to) catch all type inconsistencies in the language front-end, we may pass expressions to simplification that do not adhere to typing expectations. The included example is such a case, where the missing declaration of `memcpy` makes the struct-to-pointer cast get all the way to the middle end. Test is based on a sample generated by C-Reduce when starting from an SV-COMP task.
tautschnig
requested review from
kroening,
peterschrammel and
smowton
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5689 +/- ##
========================================
Coverage 69.49% 69.50%
========================================
Files 1243 1243
Lines 100674 100674
========================================
+ Hits 69962 69972 +10
+ Misses 30712 30702 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
peterschrammel
approved these changes
Dec 24, 2020
| main.c | ||
|
|
||
| function 'memcpy' is not declared | ||
| parameter "memcpy::dst" type mismatch |
There was a problem hiding this comment.
It seems there's some more work after #4875 left to be done. I'll create a separate PR for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we cannot (or chose not to) catch all type inconsistencies in the
language front-end, we may pass expressions to simplification that do
not adhere to typing expectations. The included example is such a case,
where the missing declaration of
memcpymakes the struct-to-pointercast get all the way to the middle end.
Test is based on a sample generated by C-Reduce when starting from an
SV-COMP task.