-
Notifications
You must be signed in to change notification settings - Fork 273
Update cbmc config to version 5.18.0. #5569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
NlightNFotis
commented
Nov 12, 2020
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
Codecov Report
@@ Coverage Diff @@
## develop #5569 +/- ##
========================================
Coverage 69.28% 69.28%
========================================
Files 1241 1241
Lines 100436 100436
========================================
Hits 69589 69589
Misses 30847 30847
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if the release commit could at least include some statement of why marking this particular state of develop as the next release is the right thing. If it's "It's Thursday, so we release" then that's ok as well, but right now it feels entirely random.
Hi @tautschnig. The regular release process is indeed every two weeks - it's documented in https://github.com/diffblue/cbmc/blob/develop/doc/ADR/release_process.md. We felt that every two weeks was a good compromise between a release cadence that's often enough to make sure we ship new features, but it's not very tight (for example every week) so that we come out with releases that don't contain new features or bug releases. Do you think this information should go somewhere else? |
I think that's perfectly good, but it would be nice if doing |